fix(Modeler): re-add outline feature #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
a team and
abdul99ahad
and removed request for
a team
nikku
force-pushed
the
re-add-outline-feature
branch
from
946a820 to
98e5079
Compare
|
I was able to verify that this fixes the problem. Fortunately, the bug has not been published yet. |
barmac
approved these changes
Nov 6, 2024
|
Was just visual in the first place. But good reminder to test modeler and viewer distributions if we perform the prior change (CC @misiekhardcore). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Turns out our custom outlines got missing with 583195a, time to restore them (for modeling).
Before
After (fixed)
Related to #2135
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}