Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup menu search #916

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Popup menu search #916

merged 2 commits into from
Sep 13, 2024

Conversation

philippfromme
Copy link
Contributor

  • adds ability for popup menu providers to provide custom search
  • default search sorts matches by location (when searching for "foo", "foo bar" will appear before "bar foo")

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 5, 2024
@philippfromme
Copy link
Contributor Author

Example usage here: https://github.com/camunda/camunda-bpmn-js/pull/367/files#diff-1abbb6d8413b72aac12009eae34de187cdc46f9c9eeb5daad527e5c7c43a8df8R23

Not entirely shure if this is the way to do it or wether we should have separate providers for search similar to: https://github.com/bpmn-io/diagram-js/blob/develop/lib/features/search-pad/SearchPadProvider.ts

@philippfromme philippfromme added the ready Ready to be worked on label Jun 25, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Jun 25, 2024
@philippfromme philippfromme force-pushed the popup-menu-search branch 2 times, most recently from e62a656 to 5f694ad Compare July 18, 2024 14:50
@philippfromme philippfromme added the needs review Review pending label Jul 23, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the ready Ready to be worked on label Jul 23, 2024
@philippfromme philippfromme marked this pull request as ready for review July 23, 2024 11:59
@philippfromme philippfromme requested a review from nikku July 23, 2024 11:59
@philippfromme philippfromme added ready Ready to be worked on and removed needs review Review pending labels Aug 21, 2024
nikku
nikku approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting back to this PR after #929 is merged. I think this is great!

image

@nikku nikku merged commit 52e5899 into develop Sep 13, 2024
11 of 12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Sep 13, 2024
@nikku nikku deleted the popup-menu-search branch September 13, 2024 14:01
@nikku
Copy link
Member

nikku commented Sep 13, 2024

Released as diagram-js@v14.11.0.

nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Sep 13, 2024
@nikku
feat(search): integrate with unified search
7c7ae48 
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
@nikku nikku mentioned this pull request Sep 13, 2024
Merged
4 tasks
nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Sep 13, 2024
@nikku
feat(search): integrate with unified search
8211c1d 
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
@nikku
Copy link
Member

nikku commented Sep 13, 2024

Example integration surfaced some issues that we may want to follow-up on: bpmn-io/bpmn-js#2235.

nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Nov 1, 2024
@nikku
feat(search): integrate with unified search
8819365 
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Nov 4, 2024
@nikku
feat(search): integrate with unified search
f55ff61 
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Nov 4, 2024
@nikku
feat(search): integrate with unified search
7743178 
This ensures we build upon the new search abstraction,
built via bpmn-io/diagram-js#916.
nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Nov 4, 2024
@nikku
feat(search): integrate with unified search
824fa1c 
This ensures we build upon the new search abstraction,
built via bpmn-io/diagram-js#916.
nikku added a commit to bpmn-io/bpmn-js that referenced this pull request Nov 5, 2024
@nikku
feat(search): integrate with unified search
8383966 
This ensures we build upon the new search abstraction,
built via bpmn-io/diagram-js#916.
@ElRaptorus ElRaptorus mentioned this pull request Jan 9, 2025
Merged
ElRaptorus added a commit to 5minds/diagram-js that referenced this pull request Feb 4, 2025
@ElRaptorus
Bump to 15.2.4 (#6)
4c383e9 
# Changes 

Siehe Changelog:
https://github.com/bpmn-io/diagram-js/blob/develop/CHANGELOG.md

## 15.2.4

* `FIX`: canvas `autoFocus` must explicitly be enabled
([bpmn-io#956](bpmn-io#956))
* `FIX`: properly integrate `zoomscroll` with canvas focus
([bpmn-io#956](bpmn-io#956))
* `FIX`: properly integrate `movecanvas` with canvas focus
([bpmn-io#956](bpmn-io#956))

## 15.2.3

* `FIX`: adjust search to prioritize start of word and exact matches
([bpmn-io#953](bpmn-io#953))
* `FIX`: ignore whitespace when searching
([bpmn-io#954](bpmn-io#954))

## 15.2.2

* `FIX`: correct `Keyboard#bind` and config types
([bpmn-io#948](bpmn-io#948))

## 15.2.1

* `FIX`: limit overly permissive regex
([bpmn-io#949](bpmn-io#949))

## 15.2.0

* `FIX`: clear selection when opening search pad
([bpmn-io#947](bpmn-io#947))
* `FIX`: correct dangling selection after search pad interaction
([bpmn-io#947](bpmn-io#947))
* `CHORE`: simplify search pad pre-selection behavior
([bpmn-io#947](bpmn-io#947))

## 15.1.0

* `FEAT`: integrate `popup-menu` with `search`
([bpmn-io#932](bpmn-io#932))
* `FEAT`: recognize modern `search` tokens in `search-pad`
([bpmn-io#932](bpmn-io#932))
* `FEAT`: improve `search` types
([bpmn-io#932](bpmn-io#932))
* `FIX`: correctly handle duplicate entries and whitespace in `search`
([bpmn-io#932](bpmn-io#932))
* `FIX`: find `search` terms across all keys
([bpmn-io#932](bpmn-io#932))
* `FIX`: `search` always returns tokens for matched items
([bpmn-io#932](bpmn-io#932))

## 15.0.0

* `FEAT`: make canvas browser selectable
([bpmn-io#659](bpmn-io#659))
* `FEAT`: make keyboard binding implicit
([bpmn-io#661](bpmn-io#661))
* `FEAT`: make multi-selection outline an outline concern
([bpmn-io#944](bpmn-io#944))

### Breaking Changes

* `Keyboard` binding target can no longer be chosen. Configure keyboard
binding via the `keyboard.bind` configuration and rely on keybindings to
work if the canvas has browser focus.
([bpmn-io#661](bpmn-io#661))
* The `Canvas` is now a focusable component, that is recognized
accordingly by the browser, with all benefits for UX and interaction.
Components that pull focus from the `Canvas` during modeling must ensure
to restore the focus (if intended), via `Canvas#restoreFocus`.
([bpmn-io#661](bpmn-io#661))
* The `selection` feature does not provide visual outline by default
anymore. Use the `outline` feature to re-enable it.
([bpmn-io#944](bpmn-io#944))

## 14.11.3

* `CHORE`: simplify viewbox cloning
([bpmn-io#935](bpmn-io#935))

## 14.11.2

* `FIX`: restore search result highlight
([bpmn-io#931](bpmn-io#931))
* `FIX`: correct search result highlight not being removed
([bpmn-io#931](bpmn-io#931))
* `FIX`: do not change zoom when search openes
([bpmn-io#931](bpmn-io#931))

## 14.11.1

_Partially reverts v14.11.0._

* `FIX`: revert `search` integration into popup menu

## 14.11.0

* `FEAT`: add `search` utility
* `FEAT`: sort popup entry search results semantically
([bpmn-io#916](bpmn-io#916))

## 14.10.0

* `FEAT`: align search styling with other popups
([bpmn-io#913](bpmn-io#913))
* `CHORE`: use existing outline in search
([bpmn-io#913](bpmn-io#913))
* `FIX`: only commit search viewport changes on `ENTER`
([bpmn-io#913](bpmn-io#913))

## 14.9.0

* `CHORE`: export types compatible with `verbatimModuleSyntax`
([bpmn-io#927](bpmn-io#927),
[bpmn-io#864](bpmn-io#864))
* `CHORE`: re-compute context pad position next frame
([bpmn-io#920](bpmn-io#920))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku