fix(schema): allow rows to be empty in form schema

bpmn-io · Nov 1, 2023 · 156cecd · 156cecd
1 parent 2220f19
commit 156cecd
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/packages/form-json-schema/src/defs/layout.json b/packages/form-json-schema/src/defs/layout.json
@@ -6,7 +6,7 @@
   "properties": {
     "row": {
       "$id": "/#component/layout/row",
-      "type": "string",
+      "type": [ "string", "null" ],
       "description": "Row in which a form field is placed."
     },
     "columns": {

diff --git a/packages/form-json-schema/test/fixtures/layout-empty-row.js b/packages/form-json-schema/test/fixtures/layout-empty-row.js
@@ -0,0 +1,15 @@
+export const form = {
+  type: 'default',
+  components: [
+    {
+      type: 'textfield',
+      key: 'firstName',
+      layout: {
+        row: null,
+        columns: 12
+      }
+    }
+  ]
+};
+
+export const errors = null;
diff --git a/.../form-json-schema/test/spec/schemaSpec.js → ...form-json-schema/test/spec/schema.spec.js b/.../form-json-schema/test/spec/schemaSpec.js → ...form-json-schema/test/spec/schema.spec.js
diff --git a/...m-json-schema/test/spec/validationSpec.js → ...-json-schema/test/spec/validation.spec.js b/...m-json-schema/test/spec/validationSpec.js → ...-json-schema/test/spec/validation.spec.js
@@ -102,6 +102,9 @@ describe('validation', function() {
   testForm('validate-validationType');
 
 
+  testForm('layout-empty-row');
+
+
   describe('rules - required properties', function() {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -102,6 +102,9 @@ describe('validation', function() {
		testForm('validate-validationType');


		testForm('layout-empty-row');


		describe('rules - required properties', function() {


Expand Down