-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: empty form editor state #725
Conversation
We need to update some screenshots for the visual regression tests as we have empty forms over there - that is expected. Let me take this 📸 https://github.com/bpmn-io/form-js/actions/runs/5590547092/job/15141869294?pr=725 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it looks clean 🥇
I'm adding @RomanKostka and @christian-konrad to have a look as well, please find here the demo: https://demo-336-proper-empty-state--camunda-form-playground.netlify.app/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! Let's go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
one thing i would like to change:
add a . after each sentence - this makes the message clearer to read.
Example:
One aditional thing that is not related to this issue:
We should probably try to align the BPMN.IO logo in the definition + preview window so that is stays at the same height.
Examples:
1ec5833
to
ba83488
Compare
ba83488
to
9547fc3
Compare
9547fc3
to
8e46f8a
Compare
8e46f8a
to
673ee68
Compare
673ee68
to
18563ae
Compare
b3705d8
to
18563ae
Compare
Closes #336