feat: allow tooltip re-usability #321
Conversation
bpmn-io-tasks
bot
added
needs review
bpmn-io-tasks
bot
added
in progress
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
src/assets/properties-panel.css
Outdated
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * Theming | |||
| */ | |||
| .bio-properties-panel { | |||
| :root { | |||
There was a problem hiding this comment.
Let's consider to have a shared base class instead, i.e. djs-parent or something. The alternative is that we prefix our variables (which we don't usually do at bpmn.io).
Without any of these measures we risk to clash with other variables that the user defined. These names sound very common to me.
There was a problem hiding this comment.
I doubt that we clash since the names are the color spefication (eg color-grey-225-10-15). At worst, we would override with the same color. But for safety, I added djs-parent (needs to have both that and bio-properties-panel since the latter is out of the parent)
There was a problem hiding this comment.
Let's address https://github.com/bpmn-io/properties-panel/pull/321/files#r1445841787 and we're good.
bpmn-io-tasks
bot
added
in progress
smbea
force-pushed
the
tooltip-reusable
branch
from
4deb11b to
058e0ff
Compare
bpmn-io-tasks
bot
added
needs review
feat: allow tooltip re-usability (bpmn-io/properties-panel#321) feat: word wrap FEEL expressions, textarea style (bpmn-io/properties-panel#319) fix: show scrollbars in popup editor (bpmn-io/properties-panel#319) Full changelog: https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3160
feat: allow tooltip re-usability (bpmn-io/properties-panel#321) feat: word wrap FEEL expressions, textarea style (bpmn-io/properties-panel#319) fix: show scrollbars in popup editor (bpmn-io/properties-panel#319) Full changelog: https://github.com/bpmn-io/properties-panel/blob/main/CHANGELOG.md#3160
Related to camunda/improved-canvas#18
Can be tested against camunda/improved-canvas#20