Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop EOLed PHP support #8

Closed
simPod opened this issue May 1, 2020 · 3 comments
Closed

Drop EOLed PHP support #8

simPod opened this issue May 1, 2020 · 3 comments

Comments

@simPod
Copy link
Contributor

simPod commented May 1, 2020

Hi, I'd like to refactor this a bit while dropping old PHP support (keeping 7.2+), bumping versions and adding type hints and templated annotations for psalm.

Let me know if interested. I'd do it in small PRs.
@bpolaszek
Copy link
Owner

Hey @simPod, I think it would be a good idea, like keeping the old 1.x branch for 5.3+ compatibility and introduce a 2.x version compatible for PHP7+, now that PHP7 has been widely adopted.
I'm 👍 for this!

@simPod
Copy link
Contributor Author

simPod commented Jan 15, 2021

Should I go against master then?

@bpolaszek bpolaszek mentioned this issue Jan 15, 2021
Merged
@bpolaszek
Copy link
Owner

2.0.x-dev for those PRs 🙂

@bpolaszek bpolaszek mentioned this issue Jan 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simPod @bpolaszek