-
Notifications
You must be signed in to change notification settings - Fork 4
Drop EOLed php versions #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bpolaszek is there a way to enable Actions for this repo? |
80441f5
to
b492f09
Compare
If you want to test them, I think you can temporarily remove the |
I thought pull_request would be enough but maybe it's for master only 🤔 lemme see |
That runs in my repo https://github.com/simPod/php-iterable-functions/actions/runs/488994536 Is there nothing to activate here https://github.com/bpolaszek/php-iterable-functions/actions for example? |
646817f
to
3d64729
Compare
Theoretically, all I have to do is to merge your PR, actions cannot be triggered unless there's a workflow in the repository, AFAIK. |
For v2, I was also considering:
WDYT? |
I don't know Pest so feel free to go on. I might learn something ;) I'll add CS, PHPStan and psalm in next steps. As for namespacing, yes why not! |
Codecov Report
@@ Coverage Diff @@
## 2.0.x-dev #12 +/- ##
============================================
Coverage ? 65.78%
============================================
Files ? 2
Lines ? 76
Branches ? 0
============================================
Hits ? 50
Misses ? 26
Partials ? 0 Continue to review full report at Codecov.
|
- add Github Actions to replace old CI (part 1/3) - upgrade PHPUnit to v9 - lock symfony/var-dumper to v5.2 as @stable is too wide for testing (lowest is incompatible, symfony/var-dumper/Resources/functions/dump.php is missing)
@bpolaszek let's ship this |
let's skip what? |
ship 🚢 |
LMAO 😄 That's what happens when I only had one liter of coffee on the Monday morning ☕ |
Uh oh!
There was an error while loading. Please reload this page.