Skip to content

Drop EOLed php versions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Drop EOLed php versions #12

merged 2 commits into from
Jan 18, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 15, 2021

  • add Github Actions to replace old CI (part 1/3)
  • upgrade PHPUnit to v9
  • lock symfony/var-dumper to v5.2 as @stable is too wide for testing (lowest is incompatible, symfony/var-dumper/Resources/functions/dump.php is missing)

@simPod
Copy link
Contributor Author

simPod commented Jan 15, 2021

@bpolaszek is there a way to enable Actions for this repo?

@simPod simPod force-pushed the php branch 2 times, most recently from 80441f5 to b492f09 Compare January 15, 2021 21:52
@bpolaszek
Copy link
Owner

@bpolaszek is there a way to enable Actions for this repo?

If you want to test them, I think you can temporarily remove the on.push.branches config path, so that any push on any branch triggers the CI. Or, maybe adding 2.0.x-dev in the on.pull_request.branches may work, but unsure.

@simPod
Copy link
Contributor Author

simPod commented Jan 15, 2021

I thought pull_request would be enough but maybe it's for master only 🤔 lemme see

@simPod
Copy link
Contributor Author

simPod commented Jan 15, 2021

@simPod simPod force-pushed the php branch 2 times, most recently from 646817f to 3d64729 Compare January 15, 2021 22:11
@bpolaszek
Copy link
Owner

Theoretically, all I have to do is to merge your PR, actions cannot be triggered unless there's a workflow in the repository, AFAIK.

@bpolaszek
Copy link
Owner

For v2, I was also considering:

  • Using Pest for tests, as I've started doing this in some other repositories.
  • Namespacing functions under BenTools\IterableFunctions instead of having them in the global namespace.

WDYT?

@simPod
Copy link
Contributor Author

simPod commented Jan 16, 2021

I don't know Pest so feel free to go on. I might learn something ;)

I'll add CS, PHPStan and psalm in next steps.

As for namespacing, yes why not!

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (2.0.x-dev@92fbe97). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             2.0.x-dev      #12   +/-   ##
============================================
  Coverage             ?   65.78%           
============================================
  Files                ?        2           
  Lines                ?       76           
  Branches             ?        0           
============================================
  Hits                 ?       50           
  Misses               ?       26           
  Partials             ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92fbe97...3aba740. Read the comment docs.

- add Github Actions to replace old CI (part 1/3)
- upgrade PHPUnit to v9
- lock symfony/var-dumper to v5.2 as @stable is too wide for testing (lowest is incompatible, symfony/var-dumper/Resources/functions/dump.php is missing)
@simPod
Copy link
Contributor Author

simPod commented Jan 18, 2021

@bpolaszek let's ship this

@bpolaszek
Copy link
Owner

@bpolaszek let's ship this

let's skip what?

@simPod
Copy link
Contributor Author

simPod commented Jan 18, 2021

ship 🚢 :shipit: 😄 merge

@bpolaszek
Copy link
Owner

LMAO 😄 That's what happens when I only had one liter of coffee on the Monday morning ☕

@bpolaszek bpolaszek merged commit 77ad64b into bpolaszek:2.0.x-dev Jan 18, 2021
@simPod simPod deleted the php branch January 18, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants