Skip to content

Drop useless tests as we have types now #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jan 18, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #17 (0f88db4) into 2.0.x-dev (add4fe2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           2.0.x-dev      #17   +/-   ##
==========================================
  Coverage      83.33%   83.33%           
==========================================
  Files              2        2           
  Lines             42       42           
==========================================
  Hits              35       35           
  Misses             7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add4fe2...0f88db4. Read the comment docs.

@bpolaszek
Copy link
Owner

They have already been dropped in #14.

@simPod
Copy link
Contributor Author

simPod commented Jan 18, 2021

This could be prerequisite for #13 so it's granular. But feel free to close if you wish

@bpolaszek
Copy link
Owner

As #13 is already merged, I'm closing this one if you don't mind :-)

@bpolaszek bpolaszek closed this Jan 23, 2021
@simPod
Copy link
Contributor Author

simPod commented Jan 23, 2021

@bpolaszek but there's still some diff here after I rebased for check 🤔

@bpolaszek
Copy link
Owner

Anyway, I didn't port obsolete tests on Pest since we now rely on PHP7 type hinting.

@simPod
Copy link
Contributor Author

simPod commented Jan 23, 2021

Yup, that's correct for sure. but something like tests/IterableToArrayTest.php will stay right? So those tests in diff here are redundant and can be dropped

@simPod simPod deleted the drop-tests branch January 26, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants