Refactor: move filter / map logic into IterableObject #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0.x-dev #26 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 2 3 +1
Lines 48 39 -9
===========================================
- Hits 48 39 -9
Continue to review full report at Codecov.
|
bpolaszek
force-pushed
the
refactor/move-functions-logic
branch
from
6b8fb79 to
4e8349a
Compare
Merged
bpolaszek
force-pushed
the
refactor/move-functions-logic
branch
from
4e8349a to
42fc535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #25.
As discussed in #24, map and filter logics have been moved to the
IterableObjectclass, introducing a newMappedTraversableinternal class to handle maps on traversable objects.It also fixes a bug where a filter would be applied before mapping (current test is biased), despite the opposite intention (map first, then filter).
IterableObjectunit test has been improved to test all possible combinations (null / array / Traversable input, no filter / default filter / callable filter, no mapper / callable mapper).@simPod if you've got a few minutes for reviewing 🙂