Added keyboard mode property to BPFormViewController #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UIPopover with auto layout.
|
Very good point. Agreeing on the fix. Thanks. |
bpoplauschi
added a commit
that referenced
this pull request
Mar 19, 2014
Added keyboard mode property to BPFormViewController
pagrit
added a commit
to willhaben/BPForms
that referenced
this pull request
Nov 23, 2017
use safearea layout guides also for right, top and left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing a lot of crashing trying to use BPFormViewController in a popover on iPad. It would try to move the form view, but the popover would also try to adjust, and Autolayout freaked out.
This change performs a check for a popover superview by default, if one is found the view does not try to resize in response to the keyboard. I also expose the
keyboardModeproperty so you have the choice to forcibly respond to the keyboard, or not.