Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for index expressions and SUM builtin #70

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bpowers
Copy link
Owner

@bpowers bpowers commented Jul 30, 2022

two major pieces here: expanding the lexer + parser to support the full array indexing syntax. Second is supporting the array version of min and max builtins, along with the array-only rank, size, stddev, and sum.

@bpowers bpowers marked this pull request as draft July 30, 2022 16:07
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (a0ea145) 72.86% compared to head (91a50eb) 77.68%.
Report is 9 commits behind head on main.

❗ Current head 91a50eb differs from pull request most recent head 292a7b2. Consider uploading reports for the commit 292a7b2 to get more accurate results

Files Patch % Lines
src/simlin-engine/src/compiler.rs 17.46% 52 Missing ⚠️
src/simlin-engine/src/builtins.rs 48.64% 38 Missing ⚠️
src/simlin-engine/src/units_check.rs 0.00% 23 Missing ⚠️
src/simlin-engine/src/ast.rs 25.00% 12 Missing ⚠️
src/simlin-engine/src/units_infer.rs 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   72.86%   77.68%   +4.81%     
==========================================
  Files          25       28       +3     
  Lines        6166     8079    +1913     
==========================================
+ Hits         4493     6276    +1783     
- Misses       1673     1803     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpowers bpowers force-pushed the sum-and-index-exprs branch 3 times, most recently from 91a50eb to 4e6d550 Compare September 21, 2022 16:15
@bpowers bpowers force-pushed the sum-and-index-exprs branch from 4e6d550 to dfaf219 Compare September 18, 2023 18:49
@bpowers bpowers force-pushed the sum-and-index-exprs branch from 292a7b2 to 45139a4 Compare July 28, 2024 21:23
@bpowers bpowers force-pushed the sum-and-index-exprs branch from 45139a4 to 9904509 Compare November 5, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant