Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use ESM #148

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

koshea
Copy link
Contributor

@koshea koshea commented Nov 6, 2024

Updates dependencies including to latest Node LTS. Latest version of yaml-import now only supports ESM, so also migrates to using import syntax.

Adjusts the contributing document to reference the new name of the vsce CLI package.

@bpruitt-goddard
Copy link
Owner

Looks good aside from the CI issue. I was able to build and get all tests passing locally 👍

@bpruitt-goddard
Copy link
Owner

Sorry can you also rebase with master? It looks like its failing now due to merge conflicts in package.json and package-lock

koshea and others added 3 commits November 8, 2024 17:14
@koshea
Copy link
Contributor Author

koshea commented Nov 8, 2024

Sorry can you also rebase with master? It looks like its failing now due to merge conflicts in package.json and package-lock

No problem, all set.

@bpruitt-goddard
Copy link
Owner

Sorry, can you make one last check to pass CI: can you update package.lock based on the CI run?

npm error code EUSAGE
npm error
npm error npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. > Please update your lock file with npm install before continuing.
npm error
npm error Missing: prettier@3.3.3 from lock file

@bpruitt-goddard bpruitt-goddard merged commit dff0421 into bpruitt-goddard:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants