Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser of build output has time of log in filename #41

Closed
tatdakar opened this issue May 30, 2022 · 3 comments
Closed

Parser of build output has time of log in filename #41

tatdakar opened this issue May 30, 2022 · 3 comments
Assignees
@Radeonmann
Labels
bug Something isn't working
Milestone
v0.0.7

Comments

@tatdakar
Copy link

In case of a compile error or warning the "Problems" view lists the issues, but they can't be linked to the actual files. The reason is that the file url has the time of the log in it resulting in an invalid path.
I recognized that on my installation the file path are absolute and in the screenshot on they are relative.
I created a new project with default settings, so i hope the issue does not result from my AS settings.
@Radeonmann Radeonmann self-assigned this May 31, 2022
@Radeonmann Radeonmann added the investigation Investigation of cause in progress label May 31, 2022
@Radeonmann
Copy link
Collaborator

Thanks for the report.

I guess it might be related to the change I introduced in #31. It seems I need to update the detection pattern.

I will plan the issue for the next release after I confirmed the error in my test environment.

@tatdakar
Copy link
Author

I downgraded to 0.0.5 and that fixed the issue. So that's probably it.

Btw, thanks for the great work!!

Radeonmann added a commit that referenced this issue Jun 11, 2022
@Radeonmann
Fixed build problem matcher pattern to skip timestamp at begin of line (
7452f6f 
#41)

The problem pattern can now handle a locale timestamp at the begin of the line. It was tested with locales:
de-CH (23:42:22)
en-US (11:42:22 PM)
zh-CN (23:42:22)
Will not work with locale strings with 'special' languages, such as zh-TW or ar-EG.
@Radeonmann Radeonmann added this to the v0.0.7 milestone Jun 11, 2022
@Radeonmann Radeonmann added bug Something isn't working and removed investigation Investigation of cause in progress labels Jun 11, 2022
@Radeonmann
Copy link
Collaborator

Fixed it and it will be in the next release.

The pattern can now handle timestamps of different locales, but it can not handle 'special' locales with non latin characters, such as zh-TW or ar-EG, as it would make the regex much more complex.

If there is the need to add more locales by someone, please open a separate issue.

Radeonmann added a commit that referenced this issue Jun 11, 2022
@Radeonmann
Added fix of #41 to changelog
dca09b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radeonmann Radeonmann

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.7
Development

No branches or pull requests
2 participants
@Radeonmann @tatdakar