Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to prettier as code formatter #56

Closed
Radeonmann opened this issue Apr 19, 2023 · 0 comments · Fixed by #58
Closed

Change to prettier as code formatter #56

Radeonmann opened this issue Apr 19, 2023 · 0 comments · Fixed by #58
Assignees
@Radeonmann
Labels
code-quality
Milestone
v0.0.8

Comments

@Radeonmann
Copy link
Collaborator

According to https://typescript-eslint.io/linting/troubleshooting/formatting/ it is bad practice to use a linter for formatting. Therefore all formatting only rules were removed from the ESLint configuration.

We will use Prettier as a formatter.

Pros:

  • Commonly used in the JS world
  • It has (almost) no configuration values, as it is fully opinionated, see their opinion on options
  • Good integration in VS code and other toolchains

Cons:

  • It has (almost) no configurations, so we cannot have our own style 😉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radeonmann Radeonmann

Labels
code-quality
Projects
None yet
Milestone
v0.0.8
Development

Successfully merging a pull request may close this issue.

Change to prettier as code formatter br-automation-com/vscode-brautomationtools
1 participant
@Radeonmann