[CLOSED] Update Mustache to v2.2.1

[core-ai-bot]

Issue by petetnt
Tuesday Dec 29, 2015 at 11:40 GMT
Originally opened as adobe/brackets#12034

---

This PR updates Mustache to version v2.2.1 from v0.7.

Mostly everything Brackets uses Mustache for works as it used to except for Mustache.compile which has been completely removed for over 2 years. This PR also provides a simple polyfill for it for not to break extensions that might still be using it.

---

petetnt included the following code: https://github.com/adobe/brackets/pull/12034/commits

[core-ai-bot]

Comment by ficristo
Tuesday Dec 29, 2015 at 12:57 GMT

---

I'm all for use up-to-date libraries, but is there any reason beyond that to update Mustache?
Did you look if there is any extension use Mustache.compile?
Maybe using something like https://github.com/dangoor/BracketsExtensionGrabber.

[core-ai-bot]

Comment by petetnt
Tuesday Dec 29, 2015 at 13:27 GMT

---

@ficristo No much other reason than it's a low hanging fruit (that I had already done when doing #12006) that could provide some performance benefits, especially for ExtensionManager if the parsing is faster (which it should be).

[core-ai-bot]

Comment by MarcelGerber
Sunday Feb 14, 2016 at 21:30 GMT

---

I had a look at updating Mustache some months ago as well, but when I did it, I faced some display issues in the Extension Manager.
So we should definitely look out for regressions.

I may get to have a look soon (at least I hope so).

[core-ai-bot]

Comment by MarcelGerber
Wednesday May 25, 2016 at 17:03 GMT

---

I've now had a look at this PR, and noticed the issue I had before is still present - in the Extension Manager dialog, extension author's names are no longer shown.

(If you need help in resolving the merge conflicts, please say so, I have a working branch local)

[core-ai-bot]

Comment by MarcelGerber
Wednesday May 25, 2016 at 17:44 GMT

---

My latest changes are up at MarcelGerber:update-mustache (see adobe/brackets@8093791...MarcelGerber:update-mustache for a changeset against current master).

I've also filed the issue with Mustache: janl/mustache.js#566

And, to complete, I've looked for extensions that use Mustache.compile and found these:

• brackets-cuwire
• brackets-wallpaper
• genuitec.team-extensions (for some reason, they have a copy of ExtensionManagerView?)
• shreder uses Mustache.compilePartial, for which we don't have a polyfill!

[core-ai-bot]

Comment by petetnt
Wednesday May 25, 2016 at 18:43 GMT

---

Blarg, screwed rebasing this PR with your changes.@MarcelGerber feel free to open a new PR with your branch. Really great work finding the issues as always, I'll check if there's a simple way to polyfill the the compilePartial method.