Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update Mustache to v2.2.1 #12034

Closed
wants to merge 223 commits into from
Closed

Update Mustache to v2.2.1 #12034

wants to merge 223 commits into from

Conversation

petetnt
Copy link
Collaborator

@petetnt petetnt commented Dec 29, 2015

This PR updates Mustache to version v2.2.1 from v0.7.

Mostly everything Brackets uses Mustache for works as it used to except for Mustache.compile which has been completely removed for over 2 years. This PR also provides a simple polyfill for it for not to break extensions that might still be using it.

Marcel Gerber and others added 26 commits January 17, 2015 19:07
Fix the misaligned selection extension when creating a folder
8b43056
@sprintr
Set Bash files syntax highlighting
75c0185
@heysupratim
Added line comment toggling only at start of code added adobe#11953
ab71656
@heysupratim
added line toggling like sublime where subsequent comment position is…
7529042 
… based on first toggle position fixed adobe#11953
@heysupratim
uneven seelcted led to wrong toggle of comments , recalucated curssor…
e2fe451 
… position for offset lines adobe#11953
@heysupratim
lint error of equality - lint is awesome
1d7e7b1
@heysupratim
removed duplicate variable declaration
66a11c7
@heysupratim
re wrote line comment test cases
95c8a6f
@heysupratim
removed lint errors in EditorCommandHandler-test.js
a230b71
@heysupratim
Merge remote-tracking branch 'upstream/master' into lineCommentBugFix
e22a55d
@swmitra
Notification on explicit cursor/selection change
2ce539f
@swmitra
Merge branch 'master' of https://github.com/adobe/brackets into swmit…
824b34d 
…ra/NavigationHistory
@swmitra
Brackets navigation between editor context
3ae64d6
@swmitra
UI for recent files
9ba2304
@swmitra
Merge branch 'master' of https://github.com/adobe/brackets into swmit…
6c986a1 
…ra/NavigationHistory
@swmitra
JSLint warning fix
a2a6636
@swmitra
Most recently opened files navigation(MROF)
c5ef6ee 
Open the list using File-> Open Recent (Alt+O)
Navigate using keyboard only - Next (Alt+Shift+N), Prev (Alt+Shift+P)
@swmitra
Click handler fix.
3598ae3
@swmitra
UI corruption fix.
713a0dd
@swmitra
Dirty dot UI corruption fix.
aa5f73e 
Minor refactoring
@swmitra
Fix for duplicate overlapping popovers.
4653810
@swmitra
Handling Left and Right arrow keys in mixed navigation (mouse+keyboard)
bec861f
@swmitra
Remove Mouse workflow
b01ca91
@ficristo
jasmine.sh: add some log to say which platform are support
d29a8fe
@swmitra
Fix for non working Ctrl+Click and Ctrl+Shift+Click for opening same …
c7e80a5 
…document on targeted panes
Update German translation
af5ab0d
@ficristo
Copy link
Collaborator

I'm all for use up-to-date libraries, but is there any reason beyond that to update Mustache?
Did you look if there is any extension use Mustache.compile?
Maybe using something like https://github.com/dangoor/BracketsExtensionGrabber.

ficristo
ficristo reviewed Dec 29, 2015
View reviewed changes
src/thirdparty/CodeMirror
@@ -1 +1 @@
Subproject commit 61ca2db598f3f1d79e837f326bc740e8bc49e62a
Subproject commit 291b06eb891ff63bc010795bd492e9a672c13566
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change belong in this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@petetnt petetnt force-pushed the petetnt/update-mustache branch from 371f492 to 7bdf720 Compare December 29, 2015 13:11
swmitra and others added 21 commits May 19, 2016 13:11
@swmitra
Changed pref string
20d40ba
@swmitra
Changed command names(replaced '.' with '-')
7d320ba
@swmitra
Resetting MROF list on prefs change
8c5c68b
@nethip
Update Document.js
0c8b2cd 
Changing `editorCount++` to `++editorCount`
@nethip
Merge pull request adobe#12405 from adobe/swmitra/RefCountFix
2a4b491 
Fix for documents refCount issue
@swmitra
Fix for workingset sync and event hldr registration
5301545
Fix ProjectModel test 'adjusts the selection if a parent folder is re…
a9c4b8c 
…named'

Test failure caused by a505026
Fix Extension Manager test failures
ce12a86 
Caused by interference between adobe#12389 and adobe#12203.
The former utilizes PathUtils, while the latter adapted PathUtils
to our normal require() workflow.
Fix CSS Code Hints test case 'should show color swatches for backgrou…
bc00259 
…nd-color'

Caused by our recent CEF upgrade
@nethip
Merge pull request adobe#12437 from adobe/marcel/test-fixes
c8a403b 
Some unit test fixes
@swmitra
Fix for EditorManager(1) and MainViewManager(4) test failures
9fdd153
@swmitra
Addressing review comments
6483f0f
Merge pull request adobe#12214 from jacobsone/refactoring
dc461c8 
Refactoring QuickOpenHTML, CSS, and JavaScript extensions
Fixup on copyright format
b7e0a22
Merge pull request adobe#12059 from ficristo/update-dependencies
c23147e 
Update a couple of dependencies in package.json at the root
@nethip
Merge pull request adobe#12439 from adobe/swmitra/AddPaneTestFix
0f5aa28 
Fix for EditorManager(1) and MainViewManager(4) test failures
@nethip
Merge pull request adobe#12012 from adobe/swmitra/NavigationHistory
59b33be 
Open Recent Files
@nethip
Bumping version Number to 1.8
f466dba
@nethip
Merge pull request adobe#12446 from adobe/prashant/VersionUpdate
8093791 
Bumping version Number to 1.8
Merge commit 'refs/pull/12034/head' of https://github.com/adobe/brackets
150f077 
 into HEAD
Update Mustache - Merge conflicts
9cccec0
@marcelgerber
Copy link
Contributor

I've now had a look at this PR, and noticed the issue I had before is still present - in the Extension Manager dialog, extension author's names are no longer shown.

(If you need help in resolving the merge conflicts, please say so, I have a working branch local)

@marcelgerber
Copy link
Contributor

marcelgerber commented May 25, 2016 •
edited
Loading

My latest changes are up at MarcelGerber:update-mustache (see 8093791...MarcelGerber:update-mustache for a changeset against current master).

I've also filed the issue with Mustache: janl/mustache.js#566

And, to complete, I've looked for extensions that use Mustache.compile and found these:

  • brackets-cuwire
  • brackets-wallpaper
  • genuitec.team-extensions (for some reason, they have a copy of ExtensionManagerView?)
  • shreder uses Mustache.compilePartial, for which we don't have a polyfill!

@petetnt petetnt closed this May 25, 2016
@petetnt petetnt deleted the petetnt/update-mustache branch May 25, 2016 18:39
@petetnt petetnt restored the petetnt/update-mustache branch May 25, 2016 18:40
@petetnt
Copy link
Collaborator Author

petetnt commented May 25, 2016

Blarg, screwed rebasing this PR with your changes. @marcelgerber feel free to open a new PR with your branch. Really great work finding the issues as always, I'll check if there's a simple way to polyfill the the compilePartial method.

@marcelgerber marcelgerber mentioned this pull request May 25, 2016
Open
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.