Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Remove deprecated code using the old preferences system #10473

Open
core-ai-bot opened this issue Aug 30, 2021 · 4 comments
Open

[CLOSED] Remove deprecated code using the old preferences system #10473

core-ai-bot opened this issue Aug 30, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by sprintr
Monday Feb 01, 2016 at 15:29 GMT
Originally opened as adobe/brackets#12182

Removed all the occurrences of PreferencesManager.convertPreferences. I have also removed its definition but that is a separate commit just in case we wanted to revert it.

Follow up of #11488 and #11174

/CC:@abose@MarcelGerber@redmunds@peterflynn@le717

sprintr included the following code: https://github.com/adobe/brackets/pull/12182/commits
@core-ai-bot
Copy link
Member Author

Comment by le717
Monday Feb 01, 2016 at 16:06 GMT

I had put up a PR to drop the old preferences system entirely in #9752, if you wanted to go that far. Since the conversion code from old to new is being removed (assuming I am reading the diff correctly), we would still have the old system lying around unused.

You may want to considering dropping setValueAndSave too.

My thought is, while the old preferences system has been deprecated for ages, convertPreferences only got a deprecation warning in v1.4 (#11174). If the definition was to be removed, has enough time lapsed for extension authors to update? IIRC, last time we looked at this, all affected extension authors had been contacted but only the actively maintained extensions were updated. Honestly, if by now if the extensions have not been updated, then there's no need to keep dragging out feet holding out.

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Tuesday Feb 02, 2016 at 02:05 GMT

@le717 The purpose of this PR was to make sure that no warnings are thrown from the core modules. I agree with you on the removal of deprecated code since it has been a quite a while since when it was deprecated. If they have not updated until now, they may not be updated ever.

I also went ahead and removed the old system from the unit tests too.

@core-ai-bot
Copy link
Member Author

Comment by MiguelCastillo
Saturday Feb 13, 2016 at 15:44 GMT

@sprintr@le717 It sounds reasonable to remove the whole thing. Do you guys think they should two separate PRs?

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Thursday Aug 25, 2016 at 22:58 GMT

This now has conflicts,@sprintr would you mind merging master to your branch so I can pull this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot