Remove deprecated code using the old preferences system #12182
Conversation
|
I had put up a PR to drop the old preferences system entirely in #9752, if you wanted to go that far. Since the conversion code from old to new is being removed (assuming I am reading the diff correctly), we would still have the old system lying around unused. You may want to considering dropping My thought is, while the old preferences system has been deprecated for ages, |
sprintr
force-pushed
the
remove-deprecated-code
branch
2 times, most recently
from
3016d05 to
491371a
Compare
|
@le717 The purpose of this PR was to make sure that no warnings are thrown from the core modules. I agree with you on the removal of deprecated code since it has been a quite a while since when it was deprecated. If they have not updated until now, they may not be updated ever. I also went ahead and removed the old system from the unit tests too. |
Add "gradle" to Groovy file extensions
…ct-fail Show an error message when trying to rename a file outside of the project
node crash fix: error on live preview server creation.
Italian strings.js for 1.7
Optimize and clean up SVG icons
codemirror/codemirror5@c65244d changed the behavior in this case; the newly inserted braces are no longer part of the resulting selection.
Updated first steps in portuguese language (pt-br)
Remove dropshadow from flip-view-buttons
Removed the word 'And' in Samples/root/index.html to make the sentence correct.
Update index.html
Update CodeMirror
Inapproriate use of win api in fs_even_node module. In fsevents_win.cpp there are a thread that monitors file system events queue and post messages to uv library. Proposed solution is to use extra bool variable in THREADINFO structure to control thread exit state
… set to 0. So removed opacity for .quick-search-container
Update Polish translation (checked and tested)
refactor, fix stats bug
…rite notifications
fix jsdoc rename fwm to FileWatcherManager remove tabs update comment add missed param to jsdoc
Make file watching compatible with node version 6.x (runs on 0.10 too)
ESLint: enable strict rule
# Conflicts: # tasks/npm-install.js
MultiBrowser Live Preview: Fix cases where url()s in CSS weren't resolved correctly
Fix Inline Editor file name underline
|
This now has conflicts, @sprintr would you mind merging master to your branch so I can pull this? |
…y when the code hint menu is open (adobe#12251) * Can now move up with ctrl+space. * Changes made suggested by PR * Found a cleaner way to do the alreadyOpen Bool. Still having trouble with the javascript '.' character hints * Remove unneeded var * Fix issues with CodeHints starting with dots * Fix wrong parameter * Changes made suggested by PR * Fix issues with CodeHints starting with dots * Fix issues with CodeHints starting with dots * Fix issues with CodeHints starting with dots * Remove unneeded var * All tests pass.
* Update Tern -> post-0.13 Replace Acorn submodule with local copy Update Acorn -> post-2.2 * Change function call for renamed function * Load ecma6.json into Tern * Workaround non-emittable options in acorn_loose * Fix unit test Since we only get 500 hints back and there have been many new additions, Date's "getSecond" was no longer part of those 500. Thus, I decided to check for the existence of hints from Function, String and Array instead of Function, Array and Date. * Make use of the correct, renamed Tern definition * remove old acorn & tern * add acorn & tern as npm dependencies add lodash as dependency * grunt install installs dependencies for extensions from npm * fix acorn & tern paths * load libraries from node_modules, not working yet fix acorn to load it with requirejs * forgot to add glob dev dependency travis builds on node 0.10 which doesn't have promise * add eslint-env node * fix missing use strict
Removed all the occurrences of
PreferencesManager.convertPreferences. I have also removed its definition but that is a separate commit just in case we wanted to revert it.Follow up of #11488 and #11174
/CC: @abose @marcelgerber @redmunds @peterflynn @le717