This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Remove old preferences system #9752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2014 23:00
Deprecated by 08e8208 in Sprint 37
| * @param {function(string)=} prefCheckCallback Optional callback function that | ||
| * examines each preference key for migration. | ||
| */ | ||
| function convertPreferences(clientID, rules, isViewState, prefCheckCallback) { |
There was a problem hiding this comment.
We should also remove all the usages of this functions in our codebase.
There was a problem hiding this comment.
I should not touch a scrap of code when I am tired...
Done.
along with any related but now unneeded functions.
|
I guess it's pretty safe to remove the old preference implementation at this point. This PR is not mergeable, but before @le717 actualizes it, we need to decide. CC @redmunds, @peterflynn |
|
Closing in favour of #12720 since is more up-to-date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8751.
This also removes
PreferencesManager.setValueAndSave(), deprecated by 08e8208 in Sprint 37. In order to prevent a repeat of Quick Open, I removed it in a separate commit in case it needs to be reverted and set my search utility to scan more thoroughly. No known extension usage was discovered./cc @dangoor