Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Remove deprecated code using the old preferences system #12720

Merged
merged 2 commits into from
Nov 22, 2016
Merged

Remove deprecated code using the old preferences system #12720

merged 2 commits into from
Nov 22, 2016

Conversation

sprintr
Copy link
Contributor

@sprintr sprintr commented Aug 26, 2016

Follow up of #12182

@zaggino zaggino added this to the Release 1.9 milestone Aug 26, 2016
@zaggino
Copy link
Contributor

zaggino commented Aug 26, 2016

To be merged for 1.9, we're nearing 1.8 release (I hope) so it'd be better to merge after release. Methods have been deprecated for over a year so it's time to remove them.

@sprintr sprintr force-pushed the remove-deprecated-code branch from 1b367f1 to d6ae906 Compare August 26, 2016 23:51
@le717
Copy link
Contributor

le717 commented Nov 21, 2016

1.8 has been released and we are currently in 1.9. Time to merge this, maybe? :D

@ficristo
Copy link
Collaborator

@le717 is there any difference with your PR?

@le717
Copy link
Contributor

le717 commented Nov 21, 2016 •
edited
Loading

@ficristo Other than this one being up-to-date (and maybe more through) and me not having the Brackets source on my computer, probably not. Just merge this one and credit @sprintr. It's cool. :)

@ficristo
Copy link
Collaborator

ficristo commented Nov 21, 2016 •
edited
Loading

not having the Brackets source on my computer

😢

@sprintr
Copy link
Contributor Author

sprintr commented Nov 21, 2016

Or merge @le717's PR, I don't even have a brackets installation. ;)

@ficristo
Copy link
Collaborator

I don't even have a brackets installation

😢

@ficristo ficristo mentioned this pull request Nov 21, 2016
Closed
zaggino
zaggino reviewed Nov 22, 2016
View reviewed changes
Copy link
Contributor

@zaggino zaggino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR seems to delete too much, are we 100% sure it only deletes unused stuff?

src/preferences/PreferencesManager.js
/**
* Save all preference clients.
*/
function savePreferences() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is being referenced for example here: https://github.com/adobe/brackets/blob/master/src/document/DocumentCommandHandlers.js#L1378

but also on multiple places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, savePreferences has been in the deprecated code.

@zaggino zaggino merged commit 33be802 into adobe:master Nov 22, 2016
@zaggino
Copy link
Contributor

zaggino commented Nov 22, 2016

Merged, gives us time to catch problems before next release if they arise.

@ficristo ficristo mentioned this pull request Nov 24, 2016
Closed
This was referenced Aug 30, 2021
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zaggino zaggino zaggino left review comments

@ficristo ficristo ficristo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@sprintr @zaggino @le717 @ficristo