Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Remove deprecated code using the old preferences system #10840

Open
core-ai-bot opened this issue Aug 30, 2021 · 8 comments
Open

[CLOSED] Remove deprecated code using the old preferences system #10840

core-ai-bot opened this issue Aug 30, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by sprintr
Friday Aug 26, 2016 at 22:41 GMT
Originally opened as adobe/brackets#12720


Follow up of #12182


sprintr included the following code: https://github.com/adobe/brackets/pull/12720/commits

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Friday Aug 26, 2016 at 22:49 GMT


To be merged for 1.9, we're nearing 1.8 release (I hope) so it'd be better to merge after release. Methods have been deprecated for over a year so it's time to remove them.

@core-ai-bot
Copy link
Member Author

Comment by le717
Monday Nov 21, 2016 at 16:15 GMT


1.8 has been released and we are currently in 1.9. Time to merge this, maybe? :D

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Monday Nov 21, 2016 at 16:24 GMT


@le717 is there any difference with your PR?

@core-ai-bot
Copy link
Member Author

Comment by le717
Monday Nov 21, 2016 at 16:26 GMT


@ficristo Other than this one being up-to-date (and maybe more through) and me not having the Brackets source on my computer, probably not. Just merge this one and credit@sprintr. It's cool. :)

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Monday Nov 21, 2016 at 16:33 GMT


not having the Brackets source on my computer

😢

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Monday Nov 21, 2016 at 17:01 GMT


Or merge@le717's PR, I don't even have a brackets installation. ;)

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Monday Nov 21, 2016 at 17:09 GMT


I don't even have a brackets installation

😢

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Tuesday Nov 22, 2016 at 20:57 GMT


Merged, gives us time to catch problems before next release if they arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant