[CLOSED] In CSSUtils, detect when in an @ rule correctly

[core-ai-bot]

Issue by MarcelGerber
Monday May 02, 2016 at 20:24 GMT
Originally opened as adobe/brackets#12397

---

Followup for #12393.
I could have sworn it worked the way I had it, but as it turned out, it doesn't. CM has also changed the context of @import from "at" to "atBlock", so now when we're inside, we deal with a "atBlock_parens".

cc@nethip@redmunds

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/12397/commits

[core-ai-bot]

Comment by redmunds
Monday May 02, 2016 at 20:44 GMT

---

This looks correct according to description above, but I haven't run the code. Can someone verify that this works? Also need to verify that broken tests are now fixed.

[core-ai-bot]

Comment by ficristo
Tuesday May 03, 2016 at 09:53 GMT

---

I see the autocomplete with this PR (I've tested against the brackets_shared.less file)
There are still 4 error on Url Code Hinting tests (on master 5 do not pass).
The CSS Code Hinting tests pass both on master and on this PR.

[core-ai-bot]

Comment by MarcelGerber
Tuesday May 03, 2016 at 14:30 GMT

---

The other 4 test failures are caused by adobe/brackets#12396.

[core-ai-bot]

Comment by ficristo
Tuesday May 03, 2016 at 15:03 GMT

---

The other 4 test failures are caused by #12396.

Good to know!

Then LGTM