This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
In CSSUtils, detect when in an @ rule correctly #12397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks correct according to description above, but I haven't run the code. Can someone verify that this works? Also need to verify that broken tests are now fixed. |
|
I see the autocomplete with this PR (I've tested against the |
|
The other 4 test failures are caused by #12396. |
Good to know! Then LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #12393.
I could have sworn it worked the way I had it, but as it turned out, it doesn't. CM has also changed the context of
@importfrom "at" to "atBlock", so now when we're inside, we deal with a "atBlock_parens".cc @nethip @redmunds