[CLOSED] CodeMirror update

[core-ai-bot]

Issue by zaggino
Wednesday Nov 23, 2016 at 05:44 GMT
Originally opened as adobe/brackets#12937

---

@adobe/brackets-committers

Latest master of CodeMirror doesn't contain built codemirror.js in the lib directory: https://github.com/codemirror/CodeMirror/tree/master/lib

Since we'll definitely want to upgrade for next version there are two options:

a) add a task to our grunt scripts that'll build codemirror.js by calling npm run build in the CodeMirror submodule
b) use CodeMirror as npm dependency

Let me know which solution you prefer.

[core-ai-bot]

Comment by petetnt
Wednesday Nov 23, 2016 at 08:58 GMT

---

Voting for b)

[core-ai-bot]

Comment by swmitra
Wednesday Nov 23, 2016 at 09:50 GMT

---

My vote for 'b'.
Off topic - We should do the same even for 'tern'. I will work on the PR where we are moving the entire JS analysis to node.

[core-ai-bot]

Comment by zaggino
Wednesday Nov 23, 2016 at 20:28 GMT

---

@petetnt@swmitra
Please also have a look at related adobe/brackets#12933
confirmed to work in adobe/brackets#12898 (comment)

[core-ai-bot]

Comment by zaggino
Wednesday Nov 23, 2016 at 23:17 GMT

---

PR here adobe/brackets#12940

[core-ai-bot]

Comment by ficristo
Monday Dec 19, 2016 at 20:37 GMT

---

Done in adobe/brackets#12972
@swmitra Acorn and Tern are already installed from npm, see adobe/brackets#11569
It would be nice to also look at adobe/brackets#12744