-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Zaggino/update extension manager deps #12933
Conversation
I would prefer if someone more familiar with webpack could take a look. |
1e495ed
to
76381c1
Compare
I'm sorry, but I am really not confident in reviewing this. |
|
I believe that src/extensibility is used by both Brackets and the Brackets Extension Registry, but I don't know the process from getting code onto the registry. @ingorichter Do you know? |
we need to tar/gzip all the js files in |
@swmitra can someone at @adobe take care of the update for https://github.com/adobe/brackets-registry or can I get access to that machine and work on it? we need to work on getting this merged so we can fix bugs related to brackets not working properly behind a proxy server |
c264a33
to
cc62ef8
Compare
updated this PR to be merge-able |
@zaggino We are looking into the registry server node upgrade request. Should be able to give you some concrete data by end of this week. |
@zaggino Since the server has upgraded node version, Could you resolve conflicts in this PR? |
…nsion-manager-deps
@saurabh95 Conflicts resolved. |
…nsion-manager-deps
@swmitra Done again :-) |
Merging this PR. Build failure is because of cla check pull failure. |
Thank a ton @zaggino for bringing this change. It makes dependency management a lot more trivial. Great work as always 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge as registry server is also upgraded to latest node.
Replacement for #10372 to keep from commiting
node_modules
to git as we should really abandon that practice where possible.Related #12898
cc @ficristo
Note: the webpack approach for semver is taken from brackets-electron, where it's implemented and works well if dependencies (in this case semver) don't provide amd build that we need to use in the browser code
Note2: sorry the diff is quite hard to read because of all the deletes, reading through commits might be easier