Odd Quick Open heuristic case

[core-ai-bot]

Issue by njx
Friday Jan 25, 2013 at 01:45 GMT
Originally opened as adobe/brackets#2663

---

1. Open the root brackets folder
2. Cmd-O
3. Type "multir"

Result: The first hit is "MultiRangeInlineEditor-test.js", but for some reason "MultiRangeInlineEditor.js" is far down the list (below noncontiguous matches like "multiple-remote.html"). I would expect these to rank closer together, and "MultiRangeInlineEditor.js" to be above things like "multiple-remote.html".

[core-ai-bot]

Comment by njx
Friday Jan 25, 2013 at 01:46 GMT

---

To@dangoor to consider--is this a bug or just an edge case?

[core-ai-bot]

Comment by dangoor
Friday Jan 25, 2013 at 01:53 GMT

---

Definitely a bug. MultiRangeInlineEditor-test.js is matching "MultiR" whereas "MultiRangeInlineEditor.js" is matching "Mult..I..r". Those two should have the same matching characters.

(side note: "mrie" is a nice quick search that takes you right to these files :)

[core-ai-bot]

Comment by njx
Friday Jan 25, 2013 at 01:59 GMT

---

Yeah, I don't think in camel-case very well :) I think it's because I type faster than I think, so it takes longer for me to strategize and think of an abbrev than to just start typing the whole thing.

[core-ai-bot]

Comment by dangoor
Friday Jan 25, 2013 at 02:13 GMT

---

That's understandable... and is precisely the challenge of trying to write code that reads people's minds relatively well...

Of course, in this case there's just something amiss that's causing these strings to match differently and nothing fundamentally wrong with its mindreading abilities :)

[core-ai-bot]

Comment by pthiess
Monday Jan 28, 2013 at 19:45 GMT

---

Reviewed, low priority.

[core-ai-bot]

Comment by dangoor
Friday May 10, 2013 at 14:00 GMT

---

Just stepping through bugs assigned to me. This bug is really weird. MultiRangeInlineEditor-test and MultiRangeInlineEditor should not be matched as differently as they are. There's some reason that the -test is following a different code path than the main file.

I'm going to nominate this for sprint 25, because this also ties into prefix matching which has come up in a couple of different issues - #3643 #3694.

[core-ai-bot]

Comment by dangoor
Monday May 20, 2013 at 19:54 GMT

---

Not critical. Bumping to Sprint 26.

[core-ai-bot]

Comment by pthiess
Monday Jun 03, 2013 at 18:12 GMT

---

Reviewed and removed the Sprint 26 tag. We may wait until@peterflynn is back.

[core-ai-bot]

Comment by dangoor
Monday Mar 17, 2014 at 19:52 GMT

---

Low priority, but nominating for 1.0 because it ties in with the other stringmatch fixes.

[core-ai-bot]

Comment by dangoor
Monday Mar 17, 2014 at 19:52 GMT

---

#3694, #3971 #3263 are the others

[core-ai-bot]

Comment by njx
Friday Apr 11, 2014 at 16:15 GMT

---

Reviewed. Since we already have a PR up for this we'd like to take this opportunistically, but shouldn't spend too much time on it.

[core-ai-bot]

Comment by peterflynn
Friday Aug 15, 2014 at 22:37 GMT

---

Reviewed -- not required for 1.0. (We also removed the FBNC tag because the PR went stale & was closed a long time ago). But see #3971 for an idea about fixing one of the more annoying cases of this sooner.