Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [PM] Begining of #2935 #3643

Open
core-ai-bot opened this issue Aug 29, 2021 · 17 comments
Open

[CLOSED] [PM] Begining of #2935 #3643

core-ai-bot opened this issue Aug 29, 2021 · 17 comments

Comments

@core-ai-bot
Copy link
Member

Issue by WebsiteDeveloper
Saturday May 18, 2013 at 16:19 GMT
Originally opened as adobe/brackets#3902


First task for #2935
@GarthDB and@larz0 for deciding where to put this functionality in the UI


WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3902/commits

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Saturday May 18, 2013 at 16:23 GMT


Maybe we could also implement an option to insert a user defined function for sorting the tree.
I'll look at that if you think it would be intresting to add.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday May 19, 2013 at 16:36 GMT


@WebsiteDeveloper I'll need to think about this. Would be nice to have a global preference screen.

@core-ai-bot
Copy link
Member Author

Comment by gruehle
Tuesday May 21, 2013 at 17:23 GMT


To@adrocknaphobia to determine what sorting options we want to offer. After that it should go to XD to figure out the UI.

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Wednesday Jul 31, 2013 at 18:18 GMT


@adrocknaphobia any news on this?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Jul 31, 2013 at 20:15 GMT


Thoughts?

foldersorting

@core-ai-bot
Copy link
Member Author

Comment by WebsiteDeveloper
Wednesday Jul 31, 2013 at 20:35 GMT


it seems to me a perfectly minimal UI until there is a Full preference panel.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Wednesday Jul 31, 2013 at 20:58 GMT


Seems good to have a simple preference like this one, but not sure if the recent projects menu is the best place to place it. We already removed the project settings from this menu. Maybe add it to the project tree context menu?

@WebsiteDeveloper I recently created a new file compare function in FileUtils. You should use that one, passing the filenames you want to compare (adding the "0", "1", and other stuff when required). Check how it is done in the project tree sort function. You could even have the functions you created just return both filenames parsed and in the sort use the file compare function with those names.

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Jul 31, 2013 at 21:28 GMT


Agree with@TomMalbran - should be in the context menu.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Jul 31, 2013 at 21:52 GMT


@njx ok cool. Last item in the context menu?

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Jul 31, 2013 at 22:05 GMT


Yup. It seems analogous to the sorting options in the working set context menu.

Ideally I think it would have a divider above it because it's different from the other items in the menu, but we already have a lot of dividers at the bottom of the file tree context menu. The main reason Refresh is under a divider is that it doesn't operate on the current selection, unlike all the other items. Maybe we could just group "Find in..." with the ones above it (removing the divider above that), then add a divider before this sorting option.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Jul 31, 2013 at 22:19 GMT


@njx maybe we can get rid of refresh once we have the new file system?

@core-ai-bot
Copy link
Member Author

Comment by njx
Wednesday Jul 31, 2013 at 22:49 GMT


Yup, definitely. But that's a ways away.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Aug 01, 2013 at 18:18 GMT


What about grouping this with Refresh? They're the only two menu items that operate on the whole tree rather than on the item you specifically right-clicked, so they have that in common... And they are both operations that update the display of the tree (without making edits or changing anything outside the tree).

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Wednesday Feb 19, 2014 at 22:52 GMT


Now that we have a new preference file, we could just place the preference inside that file as a string or as several boolean preferences? I don't think that we need a menu item for this, so the prefs files will be a good place to put them.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Mar 17, 2014 at 21:09 GMT


Was assigned to adrock, so marking "Needs Review". Note that this is now a preference, so it just needs a place in the UI.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 17, 2014 at 21:12 GMT


Do we need all this sort options? We now have a pref to sort directories on top, which is what users asked for. If we want all the options, maybe an icon with a new menu like is done in th working set, might be the way to do the UI

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Apr 01, 2014 at 20:40 GMT


Sorry@WebsiteDeveloper for letting this languish.

It turns out this got implemented independently already as a preference in Brackets, and would eventually expose it in the standard preferences UI when we have that. We could also eventually decide to expose a number of preferences related to the file tree somewhere near the tree itself, but I don't think we would do that as a one-off in the project dropdown - most likely we would add a separate gear menu similar to the working set. For now, though, I don't think we should do anything until we know how the preferences UI story shapes up.

Closing - sorry again for leaving this hanging so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant