-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] [PM] Begining of #2935 #3643
Comments
Comment by WebsiteDeveloper Maybe we could also implement an option to insert a user defined function for sorting the tree. |
Comment by larz0
|
Comment by gruehle To |
Comment by WebsiteDeveloper
|
Comment by larz0 Thoughts? |
Comment by WebsiteDeveloper it seems to me a perfectly minimal UI until there is a Full preference panel. |
Comment by TomMalbran Seems good to have a simple preference like this one, but not sure if the recent projects menu is the best place to place it. We already removed the project settings from this menu. Maybe add it to the project tree context menu?
|
Comment by njx Agree with |
Comment by larz0
|
Comment by njx Yup. It seems analogous to the sorting options in the working set context menu. Ideally I think it would have a divider above it because it's different from the other items in the menu, but we already have a lot of dividers at the bottom of the file tree context menu. The main reason Refresh is under a divider is that it doesn't operate on the current selection, unlike all the other items. Maybe we could just group "Find in..." with the ones above it (removing the divider above that), then add a divider before this sorting option. |
Comment by larz0
|
Comment by njx Yup, definitely. But that's a ways away. |
Comment by peterflynn What about grouping this with Refresh? They're the only two menu items that operate on the whole tree rather than on the item you specifically right-clicked, so they have that in common... And they are both operations that update the display of the tree (without making edits or changing anything outside the tree). |
Comment by TomMalbran Now that we have a new preference file, we could just place the preference inside that file as a string or as several boolean preferences? I don't think that we need a menu item for this, so the prefs files will be a good place to put them. |
Comment by redmunds Was assigned to adrock, so marking "Needs Review". Note that this is now a preference, so it just needs a place in the UI. |
Comment by TomMalbran Do we need all this sort options? We now have a pref to sort directories on top, which is what users asked for. If we want all the options, maybe an icon with a new menu like is done in th working set, might be the way to do the UI |
Comment by njx Sorry It turns out this got implemented independently already as a preference in Brackets, and would eventually expose it in the standard preferences UI when we have that. We could also eventually decide to expose a number of preferences related to the file tree somewhere near the tree itself, but I don't think we would do that as a one-off in the project dropdown - most likely we would add a separate gear menu similar to the working set. For now, though, I don't think we should do anything until we know how the preferences UI story shapes up. Closing - sorry again for leaving this hanging so long. |
Issue by WebsiteDeveloper
Saturday May 18, 2013 at 16:19 GMT
Originally opened as adobe/brackets#3902
First task for #2935
@
GarthDB and@
larz0 for deciding where to put this functionality in the UIWebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3902/commits
The text was updated successfully, but these errors were encountered: