Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Update Getting started screenshot, styling for 'es' locale #2655

Open
core-ai-bot opened this issue Aug 29, 2021 · 7 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by ZweiSteinSoft
Thursday Feb 07, 2013 at 19:33 GMT
Originally opened as adobe/brackets#2801


@jasonsanjose


ZweiSteinSoft included the following code: https://github.com/adobe/brackets/pull/2801/commits

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Feb 08, 2013 at 05:42 GMT


Don't merge yet -- we need to resolve #2811 first

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Feb 08, 2013 at 23:05 GMT


Please update the CSS with the new version in root/Getting Started/main.css. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Feb 08, 2013 at 23:12 GMT


Also, please ensure that the new screenshot has a transparent (not white) background.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Feb 15, 2013 at 22:53 GMT


Please update the image to match the dimensions of root/Getting Started/screenshots/brackets-quick-edit.png 2040x1474.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Feb 15, 2013 at 23:00 GMT


Initial review complete. Sorry for the delay on the review, I've been out sick.

@core-ai-bot
Copy link
Member Author

Comment by ZweiSteinSoft
Tuesday Feb 19, 2013 at 18:21 GMT


Please update the image to match the dimensions of root

Why do the localized screenshots have to be the exact same size? Also, see #2840.

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Feb 19, 2013 at 21:21 GMT


Thanks for the reference. I prefer consistency just for the sake of it. But I suppose it still looks fine and there's precedent from@njx. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant