This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update Getting started screenshot, styling for 'es' locale #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet -- we need to resolve #2811 first |
|
Please update the CSS with the new version in |
|
Also, please ensure that the new screenshot has a transparent (not white) background. |
…ound; revert CSS from root
ghost
assigned 
|
Please update the image to match the dimensions of |
|
Initial review complete. Sorry for the delay on the review, I've been out sick. |
Why do the localized screenshots have to be the exact same size? Also, see #2840. |
|
Thanks for the reference. I prefer consistency just for the sake of it. But I suppose it still looks fine and there's precedent from @njx. Merging. |
jasonsanjose
added a commit
that referenced
this pull request
Feb 19, 2013
Update Getting started screenshot, styling for 'es' locale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jasonsanjose