[CLOSED] Two ViewCommandHandlers unit tests are failing due to font size changes on Mac.

[core-ai-bot]

Issue by RaymondLim
Monday May 13, 2013 at 01:03 GMT
Originally opened as adobe/brackets#3794

---

Run ViewCommandHandlers under Integration in Jasmine window.

Result: You get two failures with the following error messages.
Error: Expected 18 to be 17.
Error: Expected 15 to be 16.

[core-ai-bot]

Comment by RaymondLim
Monday May 13, 2013 at 01:07 GMT

---

Assign it to@redmunds since I suspect this has to do with either pull request #3757 or #3568.

[core-ai-bot]

Comment by redmunds
Monday May 13, 2013 at 15:56 GMT

---

The recent attempts to fix #3478 exposed a bug in those tests. The Editor.getTextHeight() function returns line-height, not font-size, so calculating expected size using + 2 is incorrect. Pull request #3757 change the ration of line-height to font-size from 1.25 to 1.3, so the luck of these tests passing finally ran out.

[core-ai-bot]

Comment by pthiess
Tuesday May 14, 2013 at 18:24 GMT

---

Reviewed

[core-ai-bot]

Comment by jasonsanjose
Tuesday May 14, 2013 at 23:06 GMT

---

FBNC@RaymondLim

[core-ai-bot]

Comment by RaymondLim
Tuesday May 14, 2013 at 23:18 GMT

---

Confirmed fix.