[CLOSED] Allow live preview session to live longer after a currentDocumentChange

[core-ai-bot]

Issue by jasonsanjose
Friday Aug 16, 2013 at 23:56 GMT
Originally opened as adobe/brackets#4801

---

Fix for #3970

Keeps live documents open longer. Previously documents would close after a currentDocumentChange event. Also refactors how/when we update the StaticServer request filters.

---

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/4801/commits

[core-ai-bot]

Comment by jasonsanjose
Tuesday Aug 20, 2013 at 21:29 GMT

---

Added a fix for #4786 to rewrite HTTP responses for CSSDocument too.

[core-ai-bot]

Comment by gruehle
Wednesday Aug 21, 2013 at 00:26 GMT

---

Running with a custom Live Preview Base URL is broken. The UserServerProvider class doesn't have a setRequestFilterPaths method.

[core-ai-bot]

Comment by gruehle
Wednesday Aug 21, 2013 at 00:28 GMT

---

One of the Live Development unit tests is failing.

[core-ai-bot]

Comment by gruehle
Wednesday Aug 21, 2013 at 00:30 GMT

---

Initial review complete.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Aug 21, 2013 at 18:58 GMT

---

I'm starting to think that it makes more sense to move the ServerRequestManager methods to StaticServerProvider and UserServerProvider.@gruehle thoughts?

[core-ai-bot]

Comment by jasonsanjose
Thursday Aug 22, 2013 at 04:23 GMT

---

So, I took on the refactoring. In addition to pushing ServerRequestManager down into each server provider I...

• Split them up and named them (properly) as FileServer, UserServer and StaticServer with a BaseServer base class
• I also was able to extract a lot of the path/url munging that happened in LiveDevelopment
• Moved the request filtering (StaticServer specific code) into StaticServer...brilliant 👍

[core-ai-bot]

Comment by gruehle
Thursday Aug 22, 2013 at 22:45 GMT

---

Should BaseServer.js, FileServer.js, LiveDevServerManager.js and UserServer.js be moved into a new Servers directory? That would help with source organization.

[core-ai-bot]

Comment by gruehle
Thursday Aug 22, 2013 at 22:45 GMT

---

2nd review complete.

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 23, 2013 at 04:08 GMT

---

Moved the servers to LiveDevelopment/Servers

[core-ai-bot]

Comment by TomMalbran
Friday Aug 23, 2013 at 05:42 GMT

---

I think I am done now, reviewing the JSDocs :)

[core-ai-bot]

Comment by jasonsanjose
Friday Aug 23, 2013 at 17:27 GMT

---

@gruehle ready for review