Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Dialog titles are disproportionately large compared to dialog message #4533

Open
core-ai-bot opened this issue Aug 29, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Friday Aug 23, 2013 at 20:58 GMT
Originally opened as adobe/brackets#4912


Dialog titles are now roughly double the font size of the actual dialog message:
file assoc dialog

This seems a little disproportionate considering that the "meat" of the content is often the message. I still think the message text should be 1px or so bigger... but barring that, I think at least we should tone down the header/title size a little bit so the disparity's not so huge.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Aug 23, 2013 at 20:58 GMT


Assigning@larz0 to see what you think

@core-ai-bot
Copy link
Member Author

Comment by larz0
Friday Aug 23, 2013 at 21:29 GMT


@peterflynn how about this?

screen shot 2013-08-23 at 2 28 57 pm

Font size: 22px
font-weight: 400

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Aug 24, 2013 at 02:22 GMT


@larz0 That looks pretty good to me. The title looks darker/bolder too -- intentional I assume?

Although IMHO there could be less vertical padding in the 'title bar'... how do you feel about it?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Saturday Aug 24, 2013 at 02:58 GMT


@peterflynn yes it's intentional. I'll try a smaller height for the title bar; right now the title bar and the footer have the same height, if we only change the title bar height then it could look a little unstable.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Tuesday Oct 01, 2013 at 20:52 GMT


Fixed by #4930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant