Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] [Core][Quick Docs]: URL and CSS Property name tag on the left column in Quick Docs cannot be wrapped when resize the window. #5252

Open
core-ai-bot opened this issue Aug 30, 2021 · 20 comments
Open

[CLOSED] [Core][Quick Docs]: URL and CSS Property name tag on the left column in Quick Docs cannot be wrapped when resize the window. #5252

core-ai-bot opened this issue Aug 30, 2021 · 20 comments

Comments

@core-ai-bot
Copy link
Member

Issue by julieyuan
Monday Oct 28, 2013 at 08:33 GMT
Originally opened as adobe/brackets#5726

Steps:

  1. Launch Brackets and open a CSS file
  2. Put the cursor in a property name, like: text-shadow, word-wrap (sample file please refer to here)
  3. Press Cmd-K to open Quick Docs.
  4. Drag the right sidebar to the left.

Result:
The URL and property name tag are not wrapped and appears on the right column.

Expected:
They should be wrapped and only appears on the left column.

ENV: MAC10.8 and Win8.1 English OS
Build: 0.33.0-9858

Snapshots:
Please refer to snapshots for details:
11
22
@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Oct 28, 2013 at 08:48 GMT

@julieyuan Has this always been the case (e.g. back in Sprint 24 when Quck Docs was introduced)? Or is it a more recent regression?

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Monday Oct 28, 2013 at 09:06 GMT

@peterflynn I think this issue is caused by the change of webdocs. I checked it with Sprint 30, it not reproduces for the content is not the same. But it indeed reproduces in Sprint 32. Here is the snapshot with Sprint 30 for reference:
screen shot 2013-10-28 at 2 00 36 am

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Oct 28, 2013 at 16:26 GMT

It was introduced when we added the close button to the inline editor.@larz0 can you try to fix it in the css?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Oct 28, 2013 at 17:30 GMT

@RaymondLim yes I can take this one.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Oct 28, 2013 at 18:24 GMT

@RaymondLim pull request is up.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Oct 28, 2013 at 18:42 GMT

Marking low pri, fix in progress.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Oct 28, 2013 at 20:37 GMT

FBNC to@julieyuan

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Wednesday Oct 30, 2013 at 02:11 GMT

Thanks@larz0 for fixing this issue. Checked it with build 0.33.0-10187. These two properties above are fixed.Here is the snapshot for reference:
5726
For this issue, I have a little bit confusion. Is it possible that the URL is wrapped by word ? I mean, it is wrapped as:
css/
properties/
wrap
instead of :
cs
c/properties/word-
wrap
Anyway,the fix right now is already good enough 👍
If it could be wrapped by word and be fixed easily, it will be an improvement, but it is not necessary if it needs much effort.

There is another related issue.When I checked this issue, I found that anoter property box-shadow is not wrapped correctly with long string. Here is the snapshot for details:
capture decran 2013-10-29 a 7 02 22 pm

@RaymondLim or@larz0 , could you help to take a look?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Wednesday Oct 30, 2013 at 02:42 GMT

@RaymondLim new pull request is up.

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Thursday Oct 31, 2013 at 07:58 GMT

Please also note the property of background-color and background-image. Here is the snapshot with build 0.33.0-10191:
screen shot 2013-10-31 at 12 56 01 am

@core-ai-bot
Copy link
Member Author

Comment by larz0
Thursday Oct 31, 2013 at 19:17 GMT

Thanks@julieyuan this is fixed in #5755 (Breaking words for the entire column.)

screen shot 2013-10-31 at 12 16 20 pm

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Nov 03, 2013 at 10:30 GMT

@larz0 Wouldn't it be better to use word-wrap: break-word; instead of word-break: break-all; as this breaks the words in a more normal way?

Currently:
image

With word-wrap:
image

And it also does it's job when there is such an situation as in your screen of background-color.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday Nov 03, 2013 at 16:40 GMT

Thanks@SAPlayer I'll take a look. Not sure why the hyphens property isn't working.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Sunday Nov 03, 2013 at 17:32 GMT

@larz0
I did verify that@SAPlayer 's change works for all the reported issues. And the hyphens property is also working for me. Are you saying it's not working with the change to word-wrap property?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday Nov 03, 2013 at 18:01 GMT

@RaymondLim I couldn't get hyphens to work for Background-Color using word-wrap: break-word

screen shot 2013-11-03 at 9 59 05 am

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Sunday Nov 03, 2013 at 18:12 GMT

@larz0 That's correct behavior in your screenshot since your first column width is too narrow to fit background-, but it should break at hyphen if your column width is wider to fit more than background- as in the following screenshot.
quickdocbkgdcolor

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday Nov 03, 2013 at 18:33 GMT

@RaymondLim the pull request is up adobe/brackets#5835

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Sunday Nov 03, 2013 at 18:37 GMT

@larz0 Sorry that I misunderstood you on hyphens property. I just tried it on Safari browser to see what it is used for. But again, it is not yet supported in Chrome and therefore never worked since your first version.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Nov 05, 2013 at 13:49 GMT

Thanks@larz0, looks good.

@core-ai-bot
Copy link
Member Author

Comment by julieyuan
Wednesday Nov 06, 2013 at 02:21 GMT

Checked this issue with build 0.34.0-10270. It is fixed. Thanks a lot.
Closing it. Here are snapshots for reference:
background
box-shadow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot