This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Small cosmetic tweaks. #5835
Merged
Small cosmetic tweaks. #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -450,7 +450,7 @@ define(function (require, exports, module) { | |||
| $previewContainer.find(".image-preview > img").on("load", function () { | |||
| $previewContent | |||
| .append("<div class='img-size'>" + | |||
| this.naturalWidth + " x " + this.naturalHeight + " " + Strings.UNIT_PIXELS + | |||
| this.naturalWidth + " × " + this.naturalHeight + " " + Strings.UNIT_PIXELS + | |||
There was a problem hiding this comment.
Should be × instead of raw high-ascii character.
|
Done with review. |
|
@RaymondLim fixed. |
| @@ -98,7 +98,7 @@ define(function (require, exports, module) { | |||
| $("#img-preview").on("load", function () { | |||
| // add dimensions and size | |||
| _naturalWidth = this.naturalWidth; | |||
| var dimensionString = _naturalWidth + " x " + this.naturalHeight + " " + Strings.UNIT_PIXELS; | |||
| var dimensionString = _naturalWidth + " × " + this.naturalHeight + " " + Strings.UNIT_PIXELS; | |||
There was a problem hiding this comment.
Now we're using html. So we also need to change .text on line 106 to .html.
There was a problem hiding this comment.
Do we still need to change 106 even though we're using html() on 110?
There was a problem hiding this comment.
Yes, we do. Since dimensionString is no longer plain text and line 110 is for the case where stat call does not return any error. In the rare case that the stat call returns an error (ie, we can't get the image size), then we still want to show dimensionString as html.
|
Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.