Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Defer most Quick View processing until after delay #7156

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

[CLOSED] Defer most Quick View processing until after delay #7156

core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Friday May 30, 2014 at 17:56 GMT
Originally opened as adobe/brackets#7988


This is for #6538. This uses the getHoveredEditor() function from@SAPlayer's pull request #6571, so this is a replacement of that PR.

Details:

  • only processes mousemove event in requestAnimationFrame()
  • defers all processing until after setTimeout() delay
  • exception: when Quick View is already being displayed, then processing is immediate

Results:
I did some simple profiling on Win7 using the src/extensions/default/QuickView/unittest-files/test.css file and Process Explorer. I moved mouse over the css rules in that file at an even pace -- so that only mouse processing was executed (i.e. didn't stop long enough to display Quick View).

  • Before: cpu averages ~2%
  • After: cpu averages ~1%

cc:@peterflynn,@dangoor

Note: this is a squashed version of PR #6697 (which was used for testing a Travis problem, so had several unnecessary commits)


redmunds included the following code: https://github.com/adobe/brackets/pull/7988/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant