Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Handle case matches on special characters (extra boost). #8575

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] Handle case matches on special characters (extra boost). #8575

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by dangoor
Tuesday Oct 21, 2014 at 18:43 GMT
Originally opened as adobe/brackets#9621


This is a fix for #3263.

cc@JeffryBooher


dangoor included the following code: https://github.com/adobe/brackets/pull/9621/commits

@core-ai-bot
Copy link
Member Author

Comment by dangoor
Tuesday Oct 21, 2014 at 18:46 GMT


@JeffryBooher I saw that@MarcelGerber marked #3263 as a dupe of #3971 but it turns out that the change that landed on master didn't fix #3263. I took a quick look and realized that the fix for #3971 did not spot case matches on the special characters, which I think is actually pretty important.

If you look at the goodRelativeOrdering tests, you'll see that there were some tweaks to the expected ordering of things. It's impossible to make everyone happy all of the time. But, with this change you'll pretty reliably see things bubble to the top if you match case on the specials.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Oct 21, 2014 at 18:48 GMT


@dangoor thanks. I will take a look in a bit. Thanks for doing this.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Tuesday Oct 21, 2014 at 21:13 GMT


LGTM. All tests pass, Quick View promotes Case matches to the top of the list. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant