Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Handle case matches on special characters (extra boost). #9621

Merged
merged 1 commit into from
Oct 21, 2014

Conversation

dangoor
Copy link
Contributor

@dangoor dangoor commented Oct 21, 2014

This is a fix for #3263.

cc @JeffryBooher

@dangoor
Copy link
Contributor Author

dangoor commented Oct 21, 2014

@JeffryBooher I saw that @marcelgerber marked #3263 as a dupe of #3971 but it turns out that the change that landed on master didn't fix #3263. I took a quick look and realized that the fix for #3971 did not spot case matches on the special characters, which I think is actually pretty important.

If you look at the goodRelativeOrdering tests, you'll see that there were some tweaks to the expected ordering of things. It's impossible to make everyone happy all of the time. But, with this change you'll pretty reliably see things bubble to the top if you match case on the specials.

@JeffryBooher
Copy link
Contributor

@dangoor thanks. I will take a look in a bit. Thanks for doing this.

@JeffryBooher JeffryBooher self-assigned this Oct 21, 2014
@JeffryBooher
Copy link
Contributor

LGTM. All tests pass, Quick View promotes Case matches to the top of the list. Nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants