[CLOSED] Get rid of deprecation warnings in LiveDevMultiBrowser

[core-ai-bot]

Issue by busykai
Saturday Jan 31, 2015 at 16:40 GMT
Originally opened as adobe/brackets#10500

---

In case where the LiveDocument does not have a master editor, LiveDevMultiBrowser implementation uses deprecated methods to add it to the working set and open if there's no other documents.

CC@redmunds

---

busykai included the following code: https://github.com/adobe/brackets/pull/10500/commits

[core-ai-bot]

Comment by redmunds
Wednesday Feb 04, 2015 at 01:28 GMT

---

@JeffryBooher Can you review this small PR? It updates code deprecated by split view changes, and also updates a deprecation warning message.

[core-ai-bot]

Comment by JeffryBooher
Wednesday Feb 04, 2015 at 01:45 GMT

---

@redmunds LGTM -- just the one comment.

[core-ai-bot]

Comment by busykai
Thursday Feb 05, 2015 at 21:05 GMT

---

@JeffryBooher, done.

[core-ai-bot]

Comment by JeffryBooher
Thursday Feb 05, 2015 at 21:51 GMT

---

@busykai probably unrelated to this change but 3 Live Dev tests fail in the MultiBrowser (experimental) test suite:

should establish a browser connection for an opened html file
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened
should send all external stylesheets as related docs on start-up
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened
should push changes through browser connection when editing a related CSS
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened

I'm on Win 8.1 / Chrome Version 41.0.2272.35 beta-m (64-bit)

[core-ai-bot]

Comment by JeffryBooher
Thursday Feb 05, 2015 at 22:56 GMT

---

Merging this since the test failures it doesn't appear to be related. Tested and works as expected.

[core-ai-bot]

Comment by busykai
Sunday Feb 08, 2015 at 13:32 GMT

---

I'm on Win 8.1 / Chrome Version 41.0.2272.35 beta-m (64-bit)

@JeffryBooher, thanks for this data! Will take a look at it.