Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Get rid of deprecation warnings in LiveDevMultiBrowser #10500

Merged
merged 2 commits into from
Feb 5, 2015
Merged

Get rid of deprecation warnings in LiveDevMultiBrowser #10500

merged 2 commits into from
Feb 5, 2015

Conversation

busykai
Copy link
Contributor

@busykai busykai commented Jan 31, 2015

In case where the LiveDocument does not have a master editor, LiveDevMultiBrowser implementation uses deprecated methods to add it to the working set and open if there's no other documents.

CC @redmunds

@redmunds
Copy link
Contributor

redmunds commented Feb 4, 2015

@JeffryBooher Can you review this small PR? It updates code deprecated by split view changes, and also updates a deprecation warning message.

JeffryBooher
JeffryBooher reviewed Feb 4, 2015
View reviewed changes
src/LiveDevelopment/LiveDevMultiBrowser.js

if (!otherDocumentsInWorkingFiles) {
DocumentManager.setCurrentDocument(doc);
MainViewManager._edit(MainViewManager.ACTIVE_PANE, doc);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can We use DocumentCommand.CMD_ADD_TO_WORKINGSET_AND_OPEN instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, but I used CMD_OPEN instead. The file is already added to the working set (right before if).

@JeffryBooher
Copy link
Contributor

@redmunds LGTM -- just the one comment.

@busykai
Copy link
Contributor Author

busykai commented Feb 5, 2015

@JeffryBooher, done.

JeffryBooher
JeffryBooher reviewed Feb 5, 2015
View reviewed changes
src/document/DocumentManager.js
@@ -157,7 +157,7 @@ define(function (require, exports, module) {
* @return {Array.<File>}
*/
function getWorkingSet() {
DeprecationWarning.deprecationWarning("Use MainViewManager.getViews() instead of DocumentManager.getWorkingSet()", true);
DeprecationWarning.deprecationWarning("Use MainViewManager.getWorkingSet() instead of DocumentManager.getWorkingSet()", true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, btw!

@JeffryBooher
Copy link
Contributor

@busykai probably unrelated to this change but 3 Live Dev tests fail in the MultiBrowser (experimental) test suite:

should establish a browser connection for an opened html file
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened
should send all external stylesheets as related docs on start-up
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened
should push changes through browser connection when editing a related CSS
timeout: timed out after 5000 msec waiting for livedevelopment.done.opened

I'm on Win 8.1 / Chrome Version 41.0.2272.35 beta-m (64-bit)

@JeffryBooher
Copy link
Contributor

Merging this since the test failures it doesn't appear to be related. Tested and works as expected.

JeffryBooher added a commit that referenced this pull request Feb 5, 2015
@JeffryBooher
Merge pull request #10500 from adobe/kai/fix-deprecation-warnings
eb7bc01 
Get rid of deprecation warnings in LiveDevMultiBrowser
@JeffryBooher JeffryBooher merged commit eb7bc01 into master Feb 5, 2015
@JeffryBooher JeffryBooher deleted the kai/fix-deprecation-warnings branch February 5, 2015 22:57
@busykai
Copy link
Contributor Author

busykai commented Feb 8, 2015

I'm on Win 8.1 / Chrome Version 41.0.2272.35 beta-m (64-bit)

@JeffryBooher, thanks for this data! Will take a look at it.

@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@JeffryBooher JeffryBooher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busykai @redmunds @JeffryBooher