Skip to content

Update scripts to find the new location of dmd#3

Closed
RazvanN7 wants to merge 1 commit intobraddr:masterfrom
RazvanN7:Change_dmd_loc
Closed

Update scripts to find the new location of dmd#3
RazvanN7 wants to merge 1 commit intobraddr:masterfrom
RazvanN7:Change_dmd_loc

Conversation

@RazvanN7
Copy link

@RazvanN7 RazvanN7 commented May 6, 2017

No description provided.

@braddr
Copy link
Owner

braddr commented May 6, 2017

See also closed issue 1 and 2. Specifically, the windows build directory layout is not changed to match posix and this broke the testing on those platforms. The changes had to be rolled back. Get windows fixed please.

esac

$makecmd DMD=../dmd/src/dmd MODEL=$OUTPUT_MODEL $EXTRA_ARGS -f $makefile auto-tester-test >> ../phobos-unittest.log 2>&1
$makecmd DMD=../dmd/generated/*/relese/$COMPILER_MODEL/dmd MODEL=$OUTPUT_MODEL $EXTRA_ARGS -f $makefile auto-tester-test >> ../phobos-unittest.log 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release!

@RazvanN7
Copy link
Author

RazvanN7 commented May 7, 2017

@braddr could you tell us how to reproduce the error please? Is there a way to see the autotester?

@braddr
Copy link
Owner

braddr commented May 8, 2017

I didn't leave the changes in the auto-tester to fail. But you just need to build dmd on windows and observe that the output directory structure doesn't match the pattern. A quick re-look, it's missing the release vs debug directory level. It might well be incorrect in other ways/circumstances as well, but that stands out right now.

braddr@power:/home/braddr/sandbox/at-client (master)$ find master-test-Win_32_64 -name dmd.exe
master-test-Win_32_64/dmd/generated/Win_32_6432/dmd.exe
master-test-Win_32_64/dmd/src/dmd.exe

@andralex
Copy link
Contributor

andralex commented Jun 5, 2017

@RazvanN7 looks like you need to get a windows installation. Please coordinate with Eduard to get one going, you both need it. Thanks!

@RazvanN7
Copy link
Author

RazvanN7 commented Jun 8, 2017

ping @braddr I think we're good to go now

@braddr
Copy link
Owner

braddr commented Jun 8, 2017

Both stable and master are updated? Needs to be both.

@wilzbach
Copy link
Contributor

Both stable and master are updated? Needs to be both.

@braddr master has been merged into stable 24 days ago (=2017-06-17)) - so I think all changes have been propagated to stable & we should be good to go here?

@wilzbach
Copy link
Contributor

Ping @braddr - finally time to move forward with this?

@braddr
Copy link
Owner

braddr commented Sep 10, 2017

This was completed quite a while ago, sorry for forgetting to close the issue.

@braddr braddr closed this Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants