This repository has been archived by the owner on Nov 18, 2024. It is now read-only.
generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 20
Add option to make npm install
optional
#5
Merged
bradennapier
merged 5 commits into
bradennapier:master
from
luisherranz:npm-install-input
Jul 3, 2020
Merged
Add option to make npm install
optional
#5
bradennapier
merged 5 commits into
bradennapier:master
from
luisherranz:npm-install-input
Jul 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Yeah it makes sense that this is an issue - my goal was to reduce the steps needed to get this working but it makes sense to set this up better - going to see if there may be a more automated way of doing it. |
bradennapier
suggested changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know your thoughts on the suggested changes. We should probably also update the readme as-to how this would work.
As suggested by @bradennapier. Co-authored-by: Braden Napier <bradynapier+github@gmail.com>
Co-authored-by: Braden Napier <bradynapier+github@gmail.com>
I've also removed the example because now that this is automatic I don't think it makes sense anymore.
bradennapier
approved these changes
Jul 3, 2020
Ok will merge these in, however I am going to see about waiting until this major release I am working on that should make it possible to lint remote forks securely. I will let you know when released (as v3 most likely). see: #11 |
No problem. I just subscribed to the repo 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the action. It's awesome 🙂
We had a problem using it, though. We use a lerna monorepo and the
npm install
that you do inside the docker container fails, so I've added an option to avoid runningnpm install
in the container and thus allow people to run their necessary install and/or build scripts in a previous step of their workflow, like this:https://github.com/frontity/frontity/blob/refactor-analytics-event/.github/workflows/eslint.yml
The option is called
npmInstall
and has a default oftrue
.Let me know what you think.