Convert to string using rune() #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See golang/go#32479 Fix bradfitz#122. Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
cbosss
added a commit
to netlify/gomemcache
that referenced
this pull request
Mar 6, 2024
* Convert to string using rune() (bradfitz#123) See golang/go#32479 Fixes bradfitz#122. Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com> * delete an unused type * feat: add support for append/prepend * Update README.md * memcache: add Client.Close method Updates bradfitz#155 from @renanbastos93 Co-authored-by: renanbastos93 <renanbastos.tec@gmail.com> * feat: support custom dialer * support custom DialContext * add minimal Go memcached server for tests * go.mod: bump minimum Go from 1.12 to Go 1.18 Go 1.18 is what's in Ubuntu 22.04 LTS (Jammy). The later Ubuntus have 1.19, 1.20, and 1.21 (the current Go release) Go 1.18 seems fine. Go 1.18 came out 2022-03-15, about 1.5 years ago. * docs(readme): update README.md * add AUTHORS file, adjust copyright headers Signed-off-by: Brad Fitzpatrick <brad@danga.com> * add start of GitHub Actions CI * README.md: remove some dated Go notes Signed-off-by: Brad Fitzpatrick <brad@danga.com> * run the three main test types in parallel Saves about six seconds overall, as each test currently involves a three second sleep. * add CompareAndSwap (cas) tests Signed-off-by: Brad Fitzpatrick <brad@danga.com> * Export Compare-And-Swap (CAS) id in Item Even though the CAS id is a transparent token there are use cases where the client of the module could be interested in storing the token from a retrieved Item out-of-process for later use with a CAS operation. This is impossible if the field is unexported. * raise DefaultTimeout from 100ms to 500ms Various memcached concentrator things (and things with disks) are more common now (and TLS implementations with more round-trips). The assumption of all memcached access being within the same rack/LAN might no longer be appropriate. Updates bradfitz#114 Signed-off-by: Brad Fitzpatrick <brad@danga.com> * add TLS integration test, update Client.DialContext docs Turns out we already have the necessary hook (DialContext), which was added in bradfitz#158. Updates bradfitz#121 Signed-off-by: Brad Fitzpatrick <brad@danga.com> * tweak tests * move validation --------- Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com> Signed-off-by: Brad Fitzpatrick <brad@danga.com> Co-authored-by: Robert-André Mauchin <30413512+eclipseo@users.noreply.github.com> Co-authored-by: Saimon Shaplygin <semyuon@gmail.com> Co-authored-by: Justin Vanderhooft <justinvdhooft@gmail.com> Co-authored-by: Friedrich42 <39532283+Friedrich42@users.noreply.github.com> Co-authored-by: Brad Fitzpatrick <brad@danga.com> Co-authored-by: renanbastos93 <renanbastos.tec@gmail.com> Co-authored-by: Irina Marchuk <mar4ukira@gmail.com> Co-authored-by: mingrammer <mingrammer@gmail.com> Co-authored-by: martins <martin.soderstrom@aurorainnovation.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See golang/go#32479
Fix #122.
Signed-off-by: Robert-André Mauchin zebob.m@gmail.com