Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic defer-recover panic handler #53

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Add basic defer-recover panic handler #53

merged 2 commits into from
Aug 26, 2019

Conversation

bradleyjkemp
Copy link
Owner

Ideally the stream interceptor shouldn't panic but if it does (and it doesn't have it's own handler) then do something sensible to prevent grpc-proxy terminating and killing all other RPCs.

@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #53 into master will decrease coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   58.21%   58.21%   -0.01%     
==========================================
  Files          30       30              
  Lines        1089     1096       +7     
==========================================
+ Hits          634      638       +4     
- Misses        354      356       +2     
- Partials      101      102       +1
Flag Coverage Δ
#integration 57.57% <62.5%> (-0.01%) ⬇️
#unit 15.48% <0%> (-0.36%) ⬇️
Impacted Files Coverage Δ
grpc-proxy/config.go 48.57% <62.5%> (+2.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9ac20...edf6bf4. Read the comment docs.

@bradleyjkemp bradleyjkemp merged commit e11527e into master Aug 26, 2019
@bradleyjkemp bradleyjkemp deleted the panic-recover branch August 26, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant