Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Rename "get:code-challenges" to just "get:code-challenge" #26

Closed
Tracked by #32
bradtaniguchi opened this issue May 4, 2022 · 1 comment
Closed
Tracked by #32

[Enhancement] Rename "get:code-challenges" to just "get:code-challenge" #26

bradtaniguchi opened this issue May 4, 2022 · 1 comment
Assignees
@bradtaniguchi
Labels
breaking-change Things that aren't backwards compatible enhancement New feature or request

Comments

@bradtaniguchi
Copy link
Owner

Is your enhancement request related to a problem? Please describe.
The current naming convention is confusing, as this script/api only returns 1 code-challenge.

Describe the solution you'd like
Rename the script and docs from get:code-challenges to just get:code-challenge

Additional context
This technically is a breaking change and will need to be tied with a new major version.
@bradtaniguchi bradtaniguchi added enhancement New feature or request breaking-change Things that aren't backwards compatible labels May 4, 2022
@bradtaniguchi bradtaniguchi mentioned this issue May 5, 2022
Closed
5 tasks
@bradtaniguchi bradtaniguchi self-assigned this May 14, 2022
bradtaniguchi added a commit that referenced this issue May 14, 2022
@bradtaniguchi
Update docs for get:code-challenges
26fb468 
Close #26
@bradtaniguchi bradtaniguchi mentioned this issue May 14, 2022
Merged
bradtaniguchi added a commit that referenced this issue May 14, 2022
@bradtaniguchi
Update docs for get:code-challenges (#39)
f417dfd 
Close #26
@bradtaniguchi
Copy link
Owner Author

Closed with above pr, in v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradtaniguchi bradtaniguchi

Labels
breaking-change Things that aren't backwards compatible enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradtaniguchi