Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix awkward sentences in korean translation #167

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix awkward sentences in korean translation #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/Resources.ko.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
<comment>EveryHour 설명</comment>
</data>
<data name="AnErrorOccurredWhenGeneratingTheExpressionD" xml:space="preserve">
<value>표현식 설명을 생성하는 동안 오류가 발생했습니다. cron 표현식 구문을 확인합니다.</value>
<value>표현식 설명을 생성하는 동안 오류가 발생했습니다. cron 표현식 구문을 확인하세요.</value>
<comment>AnErrorOccurredWhenGeneratingTheExpressionD 설명</comment>
</data>
<data name="AtSpace" xml:space="preserve">
Expand Down Expand Up @@ -189,7 +189,7 @@
<comment>ComaEveryDay 설명</comment>
</data>
<data name="ComaEveryX0DaysOfTheWeek" xml:space="preserve">
<value>, 매 {0}요일</value>
<value>, 주 중 {0}일마다</value>
<comment>EveryX0DaysOfTheWeek 설명</comment>
</data>
<data name="ComaX0ThroughX1" xml:space="preserve">
Expand Down Expand Up @@ -233,11 +233,11 @@
<comment>OnlyOnX0 설명</comment>
</data>
<data name="ComaEveryX0Months" xml:space="preserve">
<value>, 매 {0}개월</value>
<value>, {0}개월마다</value>
<comment>EveryX0Months 설명</comment>
</data>
<data name="ComaOnlyInX0" xml:space="preserve">
<value>, {0}에서만</value>
<value>, {0}에만</value>
<comment>ComaOnlyInX0 설명</comment>
</data>
<data name="ComaOnTheLastDayOfTheMonth" xml:space="preserve">
Expand All @@ -261,7 +261,7 @@
<comment>ComaOnTheX0OfTheMonth 설명</comment>
</data>
<data name="ComaEveryX0Days" xml:space="preserve">
<value>, 매 {0}일</value>
<value>, {0}일마다</value>
<comment>ComaEveryX0Days 설명</comment>
</data>
<data name="ComaBetweenDayX0AndX1OfTheMonth" xml:space="preserve">
Expand All @@ -285,7 +285,7 @@
<comment>ComaEveryHour 설명</comment>
</data>
<data name="ComaEveryX0Years" xml:space="preserve">
<value>, 매 {0}년</value>
<value>, {0}년마다</value>
<comment>ComaEveryX0Years 설명</comment>
</data>
<data name="CommaStartingX0" xml:space="preserve">
Expand All @@ -305,6 +305,6 @@
<comment>CommaDaysBeforeTheLastDayOfTheMonth 설명</comment>
</data>
<data name="ComaOnlyInYearX0" xml:space="preserve">
<value>, {0}에서만</value>
<value>, {0}년에만</value>
</data>
</root>
24 changes: 12 additions & 12 deletions test/TestFormats.ko.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@ public void TestMinuteSpan()
[Fact]
public void TestOneMonthOnly()
{
Assert.EqualsCaseInsensitive("매분, 3월에서만", GetDescription("* * * 3 *"));
Assert.EqualsCaseInsensitive("매분, 3월에만", GetDescription("* * * 3 *"));
}

[Fact]
public void TestTwoMonthsOnly()
{
Assert.EqualsCaseInsensitive("매분, 3월 및 6월에서만", GetDescription("* * * 3,6 *"));
Assert.EqualsCaseInsensitive("매분, 3월 및 6월에만", GetDescription("* * * 3,6 *"));
}

[Fact]
Expand Down Expand Up @@ -121,14 +121,14 @@ public void TestDayOfMonth()
[Fact]
public void TestMonthName()
{
Assert.EqualsCaseInsensitive("시간 12:23 오후, 1월에서만", GetDescription("23 12 * JAN *"));
Assert.EqualsCaseInsensitive("시간 12:23 오후, 1월에만", GetDescription("23 12 * JAN *"));
}


[Fact]
public void TestDayOfMonthWithQuestionMark()
{
Assert.EqualsCaseInsensitive("시간 12:23 오후, 1월에서만", GetDescription("23 12 ? JAN *"));
Assert.EqualsCaseInsensitive("시간 12:23 오후, 1월에만", GetDescription("23 12 ? JAN *"));
}

[Fact]
Expand Down Expand Up @@ -170,7 +170,7 @@ public void TestLastDayOfTheWeekOfTheMonth()
[Fact]
public void TestLastDayOfTheMonth()
{
Assert.EqualsCaseInsensitive("매 5분, 월의 마지막 날에, 1월에서만", GetDescription("*/5 * L JAN *"));
Assert.EqualsCaseInsensitive("매 5분, 월의 마지막 날에, 1월에만", GetDescription("*/5 * L JAN *"));
}

[Fact]
Expand Down Expand Up @@ -266,19 +266,19 @@ public void TestMinutesPastTheHour()
[Fact]
public void TestOneYearOnlyWithSeconds()
{
Assert.EqualsCaseInsensitive("매초, 2013에서만", GetDescription("* * * * * * 2013"));
Assert.EqualsCaseInsensitive("매초, 2013년에만", GetDescription("* * * * * * 2013"));
}

[Fact]
public void TestOneYearOnlyWithoutSeconds()
{
Assert.EqualsCaseInsensitive("매분, 2013에서만", GetDescription("* * * * * 2013"));
Assert.EqualsCaseInsensitive("매분, 2013년에만", GetDescription("* * * * * 2013"));
}

[Fact]
public void TestTwoYearsOnly()
{
Assert.EqualsCaseInsensitive("매분, 2013 및 2014에서만", GetDescription("* * * * * 2013,2014"));
Assert.EqualsCaseInsensitive("매분, 2013 및 2014년에만", GetDescription("* * * * * 2013,2014"));
}

[Fact]
Expand Down Expand Up @@ -315,25 +315,25 @@ public void TestHoursInternalWithStepValue()
[Fact]
public void TestDayOfMonthInternalWithStepValue()
{
Assert.EqualsCaseInsensitive("시간 07:05 오전, 매 3일, 월의 2일에부터", GetDescription("0 5 7 2/3 * ? *"));
Assert.EqualsCaseInsensitive("시간 07:05 오전, 3일마다, 월의 2일에부터", GetDescription("0 5 7 2/3 * ? *"));
}

[Fact]
public void TestMonthInternalWithStepValue()
{
Assert.EqualsCaseInsensitive("시간 07:05 오전, 매 2개월, 3월~12월", GetDescription("0 5 7 ? 3/2 ? *"));
Assert.EqualsCaseInsensitive("시간 07:05 오전, 2개월마다, 3월~12월", GetDescription("0 5 7 ? 3/2 ? *"));
}

[Fact]
public void TestDayOfWeekInternalWithStepValue()
{
Assert.EqualsCaseInsensitive("시간 07:05 오전, 매 3요일, 화요일~토요일", GetDescription("0 5 7 ? * 2/3 *"));
Assert.EqualsCaseInsensitive("시간 07:05 오전, 주 중 3일마다, 화요일~토요일", GetDescription("0 5 7 ? * 2/3 *"));
}

[Fact]
public void TestYearInternalWithStepValue()
{
Assert.EqualsCaseInsensitive("시간 07:05 오전, 매 4년, 2016~9999", GetDescription("0 5 7 ? * ? 2016/4"));
Assert.EqualsCaseInsensitive("시간 07:05 오전, 4년마다, 2016~9999", GetDescription("0 5 7 ? * ? 2016/4"));
}
}
}