Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

WIP: Update typescript-eslint-parser to 21.0.1 & typescript to 3.1.6 #168

Closed
wants to merge 2 commits into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 17, 2018

Do not merge...

@bradzacher
Copy link
Owner

Hi @armano2, thanks heaps for being proactive and getting onto this.
We were having a discussion about this on #166.

I know it'll be pretty tedious, but could you please try to do this by incrementing the parser one version at a time, and PRing one at a time?

The reasoning is just being cautious; trying to prevent a potentially huge PR which is difficult to digest and review.

@armano2
Copy link
Contributor Author

armano2 commented Nov 17, 2018

ok i will do so than :(

@armano2 armano2 closed this Nov 17, 2018
@bradzacher
Copy link
Owner

thanks for understanding!

@armano2 armano2 deleted the upgrade-parser branch November 19, 2018 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants