Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheets Exporter: Support new Spreadsheet, new sheet, exists data #120

Closed
3 tasks
baruchiro opened this issue Nov 9, 2020 · 1 comment · Fixed by #151
Closed
3 tasks

Sheets Exporter: Support new Spreadsheet, new sheet, exists data #120

baruchiro opened this issue Nov 9, 2020 · 1 comment · Fixed by #151
Assignees

Comments

@baruchiro
Copy link
Collaborator

baruchiro commented Nov 9, 2020

After merging #118, need to validate the exporting to Google Spreadsheets code, includes

  • Create a new Spreadsheet by name.
  • Create a new sheet by const name.
  • Read existed data from the sheet and merge with the new data.
@baruchiro
Copy link
Collaborator Author

On second thought, creating a new Spreadsheet by name should be implemented in the UI context, since we have two different areas in the app- the config editor (the UI) and the scraping that gets the config and doing the job.

If we are putting a new spreadsheet name in the config, then passing the config as an argument to the scraping, the scraping will create a new spreadsheet, but the config still defines the Spreadsheet name.

I mean, during the scraping, the SpreadsheetId value will change from the new Spreadsheet name to its SpreadsheetId, but we are not changing the config during the scraping, so the next time the config will still be with the Spreadsheet name instead of with an already exist SpreadsheetId.

@brafdlog WDYT?

@brafdlog brafdlog mentioned this issue Dec 20, 2020
@brafdlog brafdlog linked a pull request Dec 20, 2020 that will close this issue
brafdlog pushed a commit that referenced this issue Dec 22, 2020
…on-log-4.0.7

Bump electron-log from 4.0.6 to 4.0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants