Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Github Action for PullRequest validation #49

Closed
wants to merge 4 commits into from
Closed

Create Github Action for PullRequest validation #49

wants to merge 4 commits into from

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Jun 2, 2020 •
edited
Loading

related to #36

@baruchiro baruchiro mentioned this pull request Jun 3, 2020
Closed
@baruchiro
Copy link
Collaborator Author

For the tests, we need first to merge #48, and take care of the config file in EmailSender.

Now we expecting to config file, but it failing in the build time because it does not exist. We can use environment variables instead, or add the config file with placeholder values, and then tell Git to stop track on it (I did it in my repo, but it can be a confusing solution.)

@baruchiro
Copy link
Collaborator Author

Irrelevant after merging israeli-bank-scrapers-desktop repo (#50)

@baruchiro baruchiro closed this Jun 6, 2020
@baruchiro baruchiro deleted the github-actions branch June 6, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@baruchiro