Fix: logging and empty config #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the title of this PR. Examples: See more in |
baruchiro
commented
Oct 10, 2024
Comment on lines
+19
to
+24
| const config = JSON.parse(decrypted); | ||
| if (Object.keys(config).length === 0) { | ||
| logger.log('Empty config file found, returning default config'); | ||
| return configExample; | ||
| } | ||
| return config; |
There was a problem hiding this comment.
This is a fix for my case, when the config somehow became {}. (Locally on dev env)
baruchiro
commented
Oct 10, 2024
Comment on lines
+12
to
+18
| log.initialize(); | ||
|
|
||
| // This will transport the logs to the renderer process (DevTools) in production too | ||
| log.transports.ipc.level = log.transports.file.level; | ||
|
|
||
| Object.assign(console, log.functions); | ||
| const logger = log.scope('main'); |
There was a problem hiding this comment.
initialize: Get all logs from the renderer into the main logger (the renderer can't write to file)transport.ipcdefaults tofalsefor production. Since our users learned to debug the problem with the DevTools, I think it will help to send the main logs into the renderer console.Object.assign(console, log.functions)to catch also theconsole.loga
baruchiro
commented
Oct 10, 2024
| @@ -18,19 +27,20 @@ const onError: MainErrorHandlerOptions['onError'] = ({ error }) => { | |||
| logger.error(error.message || error); | |||
| if (error.stack) logger.debug(error.stack); | |||
| }; | |||
| logger.errorHandler.startCatching({ onError }); | |||
| logger.catchErrors({ onError }); | |||
baruchiro
changed the title
shaiu
reviewed
Oct 10, 2024
| import fs from 'fs'; | ||
| import { EOL } from 'os'; | ||
| import path from 'path'; | ||
|
|
||
| log.initialize(); | ||
|
|
||
| // This will transport the logs to the renderer process (DevTools) in production too |
|
🎉 This PR is included in version 2.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the logging statements in the codebase to use the logger instead of console.log. This improves the consistency and maintainability of the logging system.
The following commits are included in this pull request:
license package.json
enable logger
Refactor logging statements to use logger instead of console.log