Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to clip out-of-dwi fiber coordinates #93

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

soichih
Copy link
Contributor

@soichih soichih commented Dec 13, 2018

Updated clipping code to handle fiber coordinates overflow (the previous patch only deals with underflow)

@francopestilli
Copy link
Contributor

@soichih how do the results of the model (say weights and rmse), built with this new changes, compare to the results in the published paper? Have you tested that already?

@soichih
Copy link
Contributor Author

soichih commented Dec 13, 2018

@francopestilli I just ran a few more tests to compare the results and they are very close; within a usual stochastic margin. Once this PR is merged, I am planning to do more thorough testings before making a new release for app-life.

@soichih
Copy link
Contributor Author

soichih commented Dec 14, 2018

More comparison
1.7
1 7

master
master

29580 ABIDEII

@francopestilli
Copy link
Contributor

@soichih ok let's try this merge we can revert if necessary.

@francopestilli francopestilli merged commit c6d514a into brain-life:master Dec 14, 2018
@ccaiafa
Copy link
Collaborator

ccaiafa commented Dec 14, 2018

Hi @soichih, as I remember, with STN and HCP we haven't had any underflow or overflow problem. I remember that when I changed ceil to round, the new rmses were a little bit better (smaller).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants